Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: simplify git hooks #445

Merged
merged 1 commit into from Apr 20, 2019
Merged

chore: simplify git hooks #445

merged 1 commit into from Apr 20, 2019

Conversation

bradzacher
Copy link
Member

Closes #259

We have too many tests to run at commit time now.
I would also say that there are too many to run at push time, as well.
Our CI will run all of the tests (incl integration tests), so there's no need to force contributors to wait through a full test cycle every commit/push.

  • change pre-commit hook to only run prettier.
    • commit hooks are used regularly, so we want it to be as lightweight as possible.
  • add pre-push hook which runs lint + typecheck + format.
    • these are all much heavier (total i find takes ~30-40s), but I think it's good to try and block pushes because of these - some of the most common errors I see are lint problems or unformatted files.

My question (for @JamesHenry, who I think added it?), is do we need commitizen? It's just admins that can push to master, otherwise all branch commits are hidden behind a squashed PR message (which is enforced via one of the PR status checks) - so enforcing a commit message style on the client seems unnecessary?

@JamesHenry JamesHenry merged commit 9559323 into master Apr 20, 2019
@JamesHenry JamesHenry deleted the cleanup-hooks branch April 20, 2019 20:23
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Out of memory error in pre-commit hook
2 participants