Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(type-utils): add basic tests for isTypeReadonly #4416

Merged

Conversation

RebeccaStevens
Copy link
Contributor

@RebeccaStevens RebeccaStevens commented Jan 9, 2022

PR Checklist

Overview

Add basic tests for isTypeReadonly.

Note: this PR is the base of #4417, #4419,#4421 and #4429

@nx-cloud
Copy link

nx-cloud bot commented Jan 9, 2022

☁️ Nx Cloud Report

CI ran the following commands for commit c7051e1. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 48 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @RebeccaStevens!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Jan 9, 2022

❌ Deploy Preview for typescript-eslint failed.

🔨 Explore the source changes: c7051e1

🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/61dd6ee114e55d0007cccfcf

@codecov
Copy link

codecov bot commented Jan 9, 2022

Codecov Report

Merging #4416 (c7051e1) into main (e61e388) will increase coverage by 0.34%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4416      +/-   ##
==========================================
+ Coverage   94.26%   94.61%   +0.34%     
==========================================
  Files         169      147      -22     
  Lines        9440     7841    -1599     
  Branches     2940     2507     -433     
==========================================
- Hits         8899     7419    -1480     
+ Misses        321      233      -88     
+ Partials      220      189      -31     
Flag Coverage Δ
unittest 94.61% <ø> (+0.34%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...escript-estree/src/semantic-or-syntactic-errors.ts
...gin-internal/src/rules/no-poorly-typed-ts-props.ts
...pt-estree/src/ts-estree/estree-to-ts-node-types.ts
packages/typescript-estree/src/convert.ts
packages/typescript-estree/src/node-utils.ts
...t-estree/src/create-program/useProvidedPrograms.ts
packages/typescript-estree/src/ast-converter.ts
packages/typescript-estree/src/convert-comments.ts
packages/typescript-estree/src/ts-estree/index.ts
packages/typescript-estree/src/version-check.ts
... and 12 more

Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks so much for adding this!

@bradzacher bradzacher merged commit ea85dda into typescript-eslint:main Jan 17, 2022
lonyele pushed a commit to lonyele/typescript-eslint that referenced this pull request Feb 12, 2022
…nt#4416)

* fix(type-utils): make isTypeReadonly's options param optional

fix typescript-eslint#4410

* test(type-utils): add basic tests for isTypeReadonly
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2022
@RebeccaStevens RebeccaStevens deleted the isTypeReadonly-tests branch March 10, 2023 23:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tests anything to do with testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants