New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: treat this
in typeof this
as a ThisExpression
#4382
Merged
Merged
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
3caf3c5
fix: support `typeof this`
Zzzen ae25168
fix: add ThisExpression to EntityName
Zzzen 1a6ef43
fix: add parser tests
Zzzen 1680e54
fix: prefer type predicate
Zzzen 92da63c
Merge remote-tracking branch 'origin/main' into typeof-this
Zzzen fdbc897
fix: update snapshot
Zzzen c924ee3
fix: update baseline
Zzzen 3aa666e
Merge branch 'main' into typeof-this
bradzacher 204c0bb
Merge remote-tracking branch 'origin/main' into typeof-this
Zzzen 3d09e4d
test: transform babel ast
Zzzen b03c226
test: fix CI error
Zzzen b699f0c
Merge branch 'main' into typeof-this
Zzzen fcbaa5d
test: refactor
Zzzen 751fd94
Merge branch 'main' into typeof-this
Zzzen df847c1
fix merge error
Zzzen a60ceee
refactor
Zzzen b9f12b9
refactor
Zzzen d42ecff
apply armano's suggested node type change
bradzacher 042c6f2
Merge branch 'main' into typeof-this
bradzacher File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add an comment with explanation why we need this and if there is babel ticket please link it here,
(this is necessary to ease maintenance of this file)