Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [array-type] correct error message for readonly #4193

Closed
wants to merge 3 commits into from

Conversation

armano2
Copy link
Member

@armano2 armano2 commented Nov 19, 2021

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Nov 19, 2021

Codecov Report

Merging #4193 (b67e626) into main (2e2ff5d) will increase coverage by 0.60%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4193      +/-   ##
==========================================
+ Coverage   92.76%   93.37%   +0.60%     
==========================================
  Files         332      152     -180     
  Lines       11524     8057    -3467     
  Branches     3285     2590     -695     
==========================================
- Hits        10690     7523    -3167     
+ Misses        361      179     -182     
+ Partials      473      355     -118     
Flag Coverage Δ
unittest 93.37% <100.00%> (+0.60%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/eslint-plugin/src/rules/array-type.ts 98.59% <100.00%> (+0.08%) ⬆️
.../experimental-utils/src/eslint-utils/RuleTester.ts
packages/scope-manager/src/lib/es2019.ts
packages/scope-manager/src/lib/es2015.symbol.ts
...s/scope-manager/src/lib/webworker.importscripts.ts
packages/typescript-estree/src/ts-estree/index.ts
...ckages/scope-manager/src/lib/webworker.iterable.ts
packages/scope-manager/src/lib/esnext.full.ts
...ges/experimental-utils/src/ts-eslint/RuleTester.ts
...ript-estree/src/create-program/createSourceFile.ts
... and 171 more

@armano2
Copy link
Member Author

armano2 commented Nov 19, 2021

no, this is not fully ok, i have to do one more fix

@armano2
Copy link
Member Author

armano2 commented Nov 19, 2021

edit; now it should be ok

@bradzacher bradzacher changed the title fix: [array-type] correct error message for readonly fix(eslint-plugin): [array-type] correct error message for readonly Nov 19, 2021
@armano2 armano2 closed this Nov 21, 2021
@armano2
Copy link
Member Author

armano2 commented Nov 21, 2021

duplicate #4066

@armano2 armano2 deleted the fix/array-type-readonly-message branch November 30, 2021 18:28
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[array-type] ReadonlyArray is regarded as Array
2 participants