Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(typescript-estree): remove workaround for import assertions #4169

Merged

Conversation

sosukesuzuki
Copy link
Contributor

PR Checklist

Sorry for creating PR without creating issue...

Overview

babel/babel#13957 has been merged to babel/parser. So we can remove workaround for Import Assertions AST alignment tests.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @sosukesuzuki!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Nov 17, 2021

✔️ Deploy Preview for typescript-eslint ready!

🔨 Explore the source changes: 530d754

🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/61947df3fb4563000846c11a

😎 Browse the preview: https://deploy-preview-4169--typescript-eslint.netlify.app

@codecov
Copy link

codecov bot commented Nov 17, 2021

Codecov Report

Merging #4169 (530d754) into master (1960152) will decrease coverage by 0.40%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4169      +/-   ##
==========================================
- Coverage   93.14%   92.73%   -0.41%     
==========================================
  Files         174      209      +35     
  Lines        9636    10003     +367     
  Branches     3013     3050      +37     
==========================================
+ Hits         8975     9276     +301     
- Misses        248      311      +63     
- Partials      413      416       +3     
Flag Coverage Δ
unittest 92.73% <ø> (-0.41%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ges/experimental-utils/src/ts-eslint/SourceCode.ts 100.00% <0.00%> (ø)
...ackages/experimental-utils/src/ts-eslint/ESLint.ts 50.00% <0.00%> (ø)
packages/experimental-utils/src/ts-eslint/Scope.ts 100.00% <0.00%> (ø)
...kages/experimental-utils/src/eslint-utils/index.ts 100.00% <0.00%> (ø)
...rimental-utils/src/ast-utils/eslint-utils/index.ts 100.00% <0.00%> (ø)
...xperimental-utils/src/ts-eslint-scope/Reference.ts 100.00% <0.00%> (ø)
...s/experimental-utils/src/eslint-utils/deepMerge.ts 89.47% <0.00%> (ø)
...experimental-utils/src/eslint-utils/RuleCreator.ts 80.00% <0.00%> (ø)
packages/experimental-utils/src/ast-utils/misc.ts 66.66% <0.00%> (ø)
.../experimental-utils/src/ts-eslint/ParserOptions.ts 100.00% <0.00%> (ø)
... and 25 more

@bradzacher bradzacher added the tests anything to do with testing label Nov 17, 2021
@bradzacher
Copy link
Member

sweet thanks for coming back to clean this up!

@bradzacher bradzacher merged commit 5a326e4 into typescript-eslint:master Nov 17, 2021
@sosukesuzuki sosukesuzuki deleted the remove-assertions-workaround branch November 17, 2021 06:04
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tests anything to do with testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants