Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: mention needing an issue for a PR in CONTRIBUTING.md #4071

Merged
merged 1 commit into from Oct 30, 2021
Merged

chore: mention needing an issue for a PR in CONTRIBUTING.md #4071

merged 1 commit into from Oct 30, 2021

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

#4066 was sent in without an attached issue. Time to make the docs more explicit?

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@nx-cloud
Copy link

nx-cloud bot commented Oct 30, 2021 •
edited

Nx Cloud Report

CI ran the following commands for commit 48b9ffc. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 Node 12.x - nx run-many --target=typecheck --all --parallel
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 12.x - nx test @typescript-eslint/parser
#000000 Node 12.x - nx test @typescript-eslint/experimental-utils
#000000 Node 12.x - nx test @typescript-eslint/scope-manager
#000000 Node 12.x - nx test @typescript-eslint/visitor-keys
#000000 Node 12.x - nx test @typescript-eslint/typescript-estree
#000000 Node 12.x - nx run-many --target=build --all --parallel
#000000 Node 12.x - nx run-many --target=build --all --parallel
#000000 Node 12.x - nx run-many --target=build --all --parallel
#000000 Node 12.x - nx prebuild @typescript-eslint/types
#000000 Node 14.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 12.x - nx prebuild @typescript-eslint/types
#000000 Node 14.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 14.x - nx test @typescript-eslint/parser
#000000 Node 12.x - nx prebuild @typescript-eslint/types
#000000 Node 14.x - nx test @typescript-eslint/experimental-utils
#000000 Node 14.x - nx test @typescript-eslint/scope-manager
#000000 Node 14.x - nx test @typescript-eslint/visitor-keys

Sent with 💌 from NxCloud.

@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Oct 30, 2021
Merged
3 tasks
@bradzacher bradzacher merged commit d8df233 into master Oct 30, 2021
@JoshuaKGoldberg JoshuaKGoldberg deleted the contributing-only-issue-pr branch October 30, 2021 18:19
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add PR template that asks for an attached issue
2 participants
@JoshuaKGoldberg @bradzacher