Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(eslint-plugin): [padding-line-between-statements] TSModuleBlock should change scope #3944

Merged
merged 3 commits into from Oct 3, 2021
Merged

fix(eslint-plugin): [padding-line-between-statements] TSModuleBlock should change scope #3944

merged 3 commits into from Oct 3, 2021

Commits on Oct 2, 2021

  1. TSModuleBlock should change scope 

    Updates the scope changes to include `TSModuleBlock`. This helps a `module` declaration be its own scope, thereby fixing false positives related to #3869
    @josephzidell
    josephzidell committed Oct 2, 2021
    Copy the full SHA
    2fcf89f View commit details
    Browse the repository at this point in the history

  2. Update the test 

    Updates the test to expect 3 errors
    @josephzidell
    josephzidell committed Oct 2, 2021
    Copy the full SHA
    c178f27 View commit details
    Browse the repository at this point in the history

  3. Removes trailing blank line 

    Removes an unnecessary trailing blank line
    @josephzidell
    josephzidell committed Oct 2, 2021
    Copy the full SHA
    b66073f View commit details
    Browse the repository at this point in the history