New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(eslint-plugin): [return-await] handle nested functions correctly #3601
fix(eslint-plugin): [return-await] handle nested functions correctly #3601
Conversation
Thanks for the PR, @MichaelBelousov! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
Nx Cloud ReportCI ran the following commands for commit 8b1f4c5. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
@bradzacher is the apparent Nx Cloud Report something that is blocking this PR? |
Codecov Report
@@ Coverage Diff @@
## master #3601 +/- ##
==========================================
+ Coverage 92.64% 92.65% +0.01%
==========================================
Files 326 326
Lines 11253 11255 +2
Branches 3171 3171
==========================================
+ Hits 10425 10428 +3
Misses 368 368
+ Partials 460 459 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@bradzacher sorry for bothering, but it's been silent so I don't know where we're at with this one. Is this slated for review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for fixing this!
fix for #3600