Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(eslint-plugin): [restrict-plus-operands] consider template literal types as strings #3234

Merged
merged 1 commit into from Apr 5, 2021
Merged

fix(eslint-plugin): [restrict-plus-operands] consider template literal types as strings #3234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/eslint-plugin/src/rules/restrict-plus-operands.ts
View file
Open in desktop
Expand Up @@ -57,7 +57,10 @@ export default util.createRule<Options, MessageIds>({
if (type.isNumberLiteral()) {
return 'number';
}
if (type.isStringLiteral()) {
if (
type.isStringLiteral() ||
util.isTypeFlagSet(type, ts.TypeFlags.TemplateLiteral)
) {
return 'string';
}
bradzacher marked this conversation as resolved.
Show resolved Hide resolved
// is BigIntLiteral
Expand Down
6 changes: 6 additions & 0 deletions packages/eslint-plugin/tests/rules/restrict-plus-operands.test.ts
View file
Open in desktop
Expand Up @@ -110,6 +110,12 @@ const x = a + b;
declare const a: 'string literal' & string;
declare const b: string;
const x = a + b;
`,
`
function A(s: string) {
return \`a\${s}b\` as const;
}
const b = A('') + '!';
`,
{
code: `
Expand Down