Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update lerna to 4.0.0 #3151

Merged
merged 5 commits into from Nov 11, 2021
Merged

chore: update lerna to 4.0.0 #3151

merged 5 commits into from Nov 11, 2021

Conversation

armano2
Copy link
Member

@armano2 armano2 commented Mar 5, 2021

No description provided.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@armano2 armano2 mentioned this pull request Mar 11, 2021
Closed
@bradzacher bradzacher added the dependencies Issue about dependencies of the package label Mar 15, 2021
bradzacher
bradzacher previously approved these changes Mar 15, 2021
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did this really generate 3k lines of changes to the yarn.lock? JFC they have too many dependencies.

@armano2
Copy link
Member Author

armano2 commented Mar 15, 2021 •
edited

they rely on conventional-changelog-parser that requires on meow and this package has 66 dependencies sindresorhus/meow#177

did this really generate 3k lines of changes to the yarn.lock? JFC they have too many dependencies.

419 lines removed :)

@armano2
Merge branch 'master'
110b416 
Conflicts:
	yarn.lock
@armano2 armano2 requested a review from bradzacher March 15, 2021 09:03
JounQin
JounQin reviewed Mar 15, 2021
View reviewed changes
package.json Outdated Show resolved Hide resolved
bradzacher
bradzacher previously approved these changes Mar 21, 2021
View reviewed changes
@bradzacher
Copy link
Member

just needs rebasing/updating to resolve the merge conflict

@bradzacher bradzacher added the awaiting response Issues waiting for a reply from the OP or another party label Mar 28, 2021
@bradzacher bradzacher added the 1 approval PR that a maintainer has LGTM'd - any maintainer can merge this when ready label Jul 6, 2021
@bradzacher bradzacher added the DO NOT MERGE PRs which should not be merged yet label Jul 31, 2021
@nx-cloud
Copy link

nx-cloud bot commented Nov 7, 2021 •
edited

Nx Cloud Report

CI ran the following commands for commit fa9792c. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-internal
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 16.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 16.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 14.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 14.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 12.x - nx test @typescript-eslint/parser
#000000 Node 12.x - nx test @typescript-eslint/experimental-utils
#000000 Node 12.x - nx test @typescript-eslint/scope-manager
#000000 Node 12.x - nx test @typescript-eslint/visitor-keys
#000000 Node 12.x - nx test @typescript-eslint/typescript-estree
#000000 Node 14.x - nx test @typescript-eslint/parser
#000000 Node 14.x - nx test @typescript-eslint/experimental-utils
#000000 Node 14.x - nx test @typescript-eslint/scope-manager
#000000 Node 16.x - nx test @typescript-eslint/parser
#000000 Node 12.x - nx test @typescript-eslint/parser
#000000 Node 16.x - nx test @typescript-eslint/experimental-utils

Sent with 💌 from NxCloud.

@armano2
Copy link
Member Author

armano2 commented Nov 7, 2021

just needs rebasing/updating to resolve the merge conflict

done

@armano2 armano2 removed the awaiting response Issues waiting for a reply from the OP or another party label Nov 7, 2021
@bradzacher
Merge branch 'master' into chore/lerna-4
e9f2b96 
# Conflicts:
#	package.json
#	yarn.lock
@netlify
Copy link

netlify bot commented Nov 11, 2021 •
edited

✔️ Deploy Preview for typescript-eslint ready!

🔨 Explore the source changes: fa9792c

🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/618cb4f116b7fc0007fbcbbb

😎 Browse the preview: https://deploy-preview-3151--typescript-eslint.netlify.app

bradzacher
bradzacher previously approved these changes Nov 11, 2021
View reviewed changes
@codecov
Copy link

codecov bot commented Nov 11, 2021 •
edited

Codecov Report

Merging #3151 (fa9792c) into master (4875cd6) will increase coverage by 0.38%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3151      +/-   ##
==========================================
+ Coverage   92.73%   93.11%   +0.38%     
==========================================
  Files         334      174     -160     
  Lines       11494     9619    -1875     
  Branches     3270     3004     -266     
==========================================
- Hits        10659     8957    -1702     
+ Misses        362      248     -114     
+ Partials      473      414      -59
Flag Coverage Δ
unittest 93.11% <ø> (+0.38%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../scope-manager/src/variable/ESLintScopeVariable.ts
packages/scope-manager/src/lib/es2019.object.ts
packages/scope-manager/src/definition/index.ts
...ckages/experimental-utils/src/ast-utils/helpers.ts
...l-utils/src/eslint-utils/batchedSingleLineTests.ts
packages/scope-manager/src/lib/es2020.promise.ts
packages/scope-manager/src/lib/esnext.full.ts
packages/scope-manager/src/lib/es2015.reflect.ts
packages/scope-manager/src/lib/es2021.weakref.ts
...s/scope-manager/src/lib/es2015.symbol.wellknown.ts
... and 150 more

@bradzacher bradzacher merged commit 3b017f0 into master Nov 11, 2021
@bradzacher bradzacher deleted the chore/lerna-4 branch November 11, 2021 06:29
armano2
armano2 commented Nov 11, 2021
View reviewed changes
package.json
"@commitlint/cli": "^14.1.0",
"@commitlint/config-conventional": "^14.1.0",
"@commitlint/config-lerna-scopes": "^14.0.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need this package anymore

@bradzacher bradzacher removed the DO NOT MERGE PRs which should not be merged yet label Nov 11, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JounQin JounQin JounQin left review comments

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
1 approval PR that a maintainer has LGTM'd - any maintainer can merge this when ready dependencies Issue about dependencies of the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@armano2 @bradzacher @JounQin