Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(typescript-estree): simplify applyModifiersToResult #3084

Merged
merged 1 commit into from Feb 21, 2021

Conversation

armano2
Copy link
Member

@armano2 armano2 commented Feb 21, 2021

Those changes has been extracted from #3078

simplifies logic used to generate deprecated modifiers field in some of nodes. instead of iterating over nodes collecting results, filtering them and mapping them again we perform entire operation in first loop

this change has negligible perf improvement

@armano2 armano2 added package: typescript-estree Issues related to @typescript-eslint/typescript-estree refactor PRs that refactor code only labels Feb 21, 2021
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Feb 21, 2021

Codecov Report

Merging #3084 (81dfe13) into master (763a252) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3084      +/-   ##
==========================================
- Coverage   92.83%   92.83%   -0.01%     
==========================================
  Files         314      314              
  Lines       10675    10671       -4     
  Branches     3027     3027              
==========================================
- Hits         9910     9906       -4     
  Misses        348      348              
  Partials      417      417              
Flag Coverage Δ
unittest 92.83% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/typescript-estree/src/convert.ts 98.36% <100.00%> (-0.01%) ⬇️

@armano2 armano2 merged commit 0469102 into master Feb 21, 2021
@armano2 armano2 deleted the refactor/apply-modifers branch February 21, 2021 23:34
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: typescript-estree Issues related to @typescript-eslint/typescript-estree refactor PRs that refactor code only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants