feat: merge AST structure of TSAsExpression with TSTypeAssertion

[armano2]

This PR aims to merge AST structure of TSAsExpression with TSTypeAssertion

This is BREAKING CHANGE

New AST structure

interface TSTypeAssertion extends Node {
  type: AST_NODE_TYPES.TSTypeAssertion;
  typeAnnotation: TypeNode;
  expression: Expression;
  kind: 'as' | 'angle-bracket';
}

TODO:

• Add unit tests for indent rule
• Add unit tests for keyword-spacing rule
• Add unit tests for no-var-requires rule

fixes #2142

[typescript-eslint]

Thanks for the PR, @armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

[armano2]

while doing this change i noticed that order of creating references was not correct

[codecov]

Codecov Report

Merging #3005 (16a89b1) into master (5e2a993) will decrease coverage by 0.01%.
The diff coverage is 76.47%.

@@            Coverage Diff             @@
##           master    #3005      +/-   ##
==========================================
- Coverage   92.87%   92.85%   -0.02%     
==========================================
  Files         314      314              
  Lines       10670    10671       +1     
  Branches     3026     3029       +3     
==========================================
- Hits         9910     9909       -1     
  Misses        344      344              
- Partials      416      418       +2     

Flag	Coverage Δ
unittest	92.85% <76.47%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...nt-plugin/src/rules/indent-new-do-not-use/index.ts	98.13% <ø> (ø)
...ackages/eslint-plugin/src/rules/keyword-spacing.ts	81.25% <0.00%> (-11.61%)	⬇️
...ackages/eslint-plugin/src/rules/no-var-requires.ts	88.88% <ø> (ø)
...ackages/eslint-plugin/src/rules/prefer-as-const.ts	100.00% <ø> (ø)
packages/eslint-plugin/src/rules/unbound-method.ts	93.10% <ø> (ø)
...ges/experimental-utils/src/ast-utils/predicates.ts	37.50% <0.00%> (+0.65%)	⬆️
...pt-estree/src/ts-estree/estree-to-ts-node-types.ts	100.00% <ø> (ø)
packages/visitor-keys/src/visitor-keys.ts	100.00% <ø> (ø)
packages/eslint-plugin/src/rules/indent.ts	89.13% <80.00%> (-1.35%)	⬇️
...int-plugin/src/rules/consistent-type-assertions.ts	84.84% <100.00%> (-1.64%)	⬇️
... and 4 more

[armano2]

there is no unit case for type assertion with brackets

[armano2]

i implemented this change but I'm unsure if this is actually good

[bradzacher]

i implemented this change but I'm unsure if this is actually good

What do you mean?
Do you mean you don't like having one node represent the two different types?

[bradzacher]

could do this via a selector

Suggested change

	TSTypeAssertion(node): void {
	if (node.kind !== 'as') {
	return;
	}
	'TSTypeAssertion[kind = "as"]'(node): void {

[bradzacher]

we could also add this as a typed selector to packages/types/src/ast-node-types.ts as it's probably going to be a more common usecase

[armano2]

What do you mean?
Do you mean you don't like having one node represent the two different types?

yes, I'm not sure if this is a good change, for sure its more convenient