New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eslint-plugin): [member-delimiter-style] Add an option 'multilineDetection' to treat types and interfaces as single line if the last member ends on the same line as the closing bracket #2970
Conversation
Thanks for the PR, @pfgithub! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Could you explain more about this and why you want this change? I'm not sure I agree that
Should be considered a "single line" type - because it's not really a single line type. |
The purpose of singleLine member delimiter style is to make single line types not need a trailing delimiter or have a different delimiter
When a type spans multiple lines but only its members have newlines, it looks weird for it to use the multiline delimiter style (especially with commas)
This change won't affect anyone using prettier because prettier doesn't allow code to be formatted like that (link) (although people using prettier probably aren't using |
To clarify - I understand the change itself, completely. I'm trying to understand the use case better. The why. This rule has existed for >2 years without this functionality.
Correct, because prettier enforces a consistent code style in this context. |
The eslint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Before this PR:
After this PR:
last-member is
brackets
by default, which keeps existing behaviour