Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for decorator metadata in scope analysis and in consistent-type-imports #2751

Merged
merged 8 commits into from
Jan 18, 2021
Merged

feat: add support for decorator metadata in scope analysis and in consistent-type-imports #2751

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ed33caa
fix(eslint-plugin): fix value import in decorator metadata
Frezc Nov 9, 2020
5b7de66
fix(eslint-plugin): test coverage
Frezc Nov 10, 2020
e24d78d
move logic
Frezc Dec 12, 2020
364f4cb
Merge remote-tracking branch 'origin/master' into fix/meta
Frezc Dec 12, 2020
843f072
fix ci
Frezc Dec 12, 2020
518d21a
class visitor
Frezc Jan 3, 2021
58324a0
Merge remote-tracking branch 'origin/master' into fix/meta
Frezc Jan 3, 2021
b631e7a
split snapshot
Frezc Jan 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/eslint-plugin/docs/rules/consistent-type-imports.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ const defaultOptions: Options = {

This option defines the expected import kind for type-only imports. Valid values for `prefer` are:

- `type-imports` will enforce that you always use `import type Foo from '...'`. It is default.
- `type-imports` will enforce that you always use `import type Foo from '...'` except referenced by metadata of decorators. It is default.
- `no-type-imports` will enforce that you always use `import Foo from '...'`.

Examples of **correct** code with `{prefer: 'type-imports'}`, and **incorrect** code with `{prefer: 'no-type-imports'}`.
Expand Down