Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(typescript-estree): export * regression from 133f622f #1751

Merged
merged 2 commits into from Mar 18, 2020
Merged

fix(typescript-estree): export * regression from 133f622f #1751

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c86e8b6
fix(typescript-estree): export * regression from 133f622f
bradzacher Mar 17, 2020
aa0e9fa
Merge branch 'master' into 1746-barrel-export-parse-bug
bradzacher Mar 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/typescript-estree/src/convert.ts
View file
Open in desktop
Expand Up @@ -1602,7 +1602,12 @@ export class Converter {
source: this.convertChild(node.moduleSpecifier),
exportKind: node.isTypeOnly ? 'type' : 'value',
exported:
node.exportClause?.kind === SyntaxKind.NamespaceExport
// note - for compat with 3.7.x, where node.exportClause is always undefined and
// SyntaxKind.NamespaceExport does not exist yet (i.e. is undefined), this
// cannot be shortened to an optional chain, or else you end up with
// undefined === undefined, and the true path will hard error at runtime
node.exportClause &&
node.exportClause.kind === SyntaxKind.NamespaceExport
? this.convertChild(node.exportClause.name)
: null,
});
Expand Down