Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(eslint-plugin): [no-unnecessary-condition] ignore basic array indexing false positives #1534

Merged
merged 7 commits into from Mar 20, 2020
Merged

feat(eslint-plugin): [no-unnecessary-condition] ignore basic array indexing false positives #1534

merged 7 commits into from Mar 20, 2020

Commits on Jan 28, 2020

  1. fix(eslint-plugin): [no-unnecessary-cond] ignore basic array index case 

    Adds a special case to suppress "unnecessary condition" errors on code like:

```ts
function example(arr: number[]) {
  // type is number, but could be undefined
  if(arr[0]) {
    //...
  }
}
```
    @Retsam
    Retsam committed Jan 28, 2020
    Copy the full SHA
    42f46c8 View commit details
    Browse the repository at this point in the history

  2. fix(eslint-plugin): [no-unnecessary-condition] tuple edge case

    @Retsam
    Retsam committed Jan 28, 2020
    Copy the full SHA
    c4d6527 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2020

  1. fix(eslint-plugin): fix array-indexing optional chain case

    @Retsam
    Retsam committed Jan 31, 2020
    Copy the full SHA
    125229d View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2020

  1. fix(eslint-plugin): handle false positive with array index and ??

    @Retsam
    Retsam committed Feb 1, 2020
    Copy the full SHA
    23eee5a View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2020

  1. chore(eslint-plugin): fix truncated comma

    @Retsam
    Retsam committed Mar 2, 2020
    Copy the full SHA
    25f318c View commit details
    Browse the repository at this point in the history

  2. chore(eslint-plugin): add suggested test cases

    @Retsam
    Retsam committed Mar 2, 2020
    Copy the full SHA
    185be85 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2020

  1. Merge branch 'master' into ignore-index-signatures

    @bradzacher
    bradzacher committed Mar 20, 2020
    Copy the full SHA
    94153b0 View commit details
    Browse the repository at this point in the history