Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: no-unnecessary-type-constraint should mention extending unknown #6973

Closed
2 tasks done
JoshuaKGoldberg opened this issue Apr 29, 2023 · 1 comment · Fixed by #6976
Closed
2 tasks done

Docs: no-unnecessary-type-constraint should mention extending unknown #6973

JoshuaKGoldberg opened this issue Apr 29, 2023 · 1 comment · Fixed by #6976
Labels
accepting prs Go ahead, send a pull request that resolves this issue documentation Documentation ("docs") that needs adding/updating good first issue Good for newcomers package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin

Comments

@JoshuaKGoldberg
Copy link
Member

Before You File a Documentation Request Please Confirm You Have Done The Following...

Suggested Changes

@MichaelDeBoey raises an excellent point in remix-run/remix#6248 (comment):

The docs are talking about any only, but this had unknown Does the same apply? If so, I guess it would be a good idea to update the docs?

Agreed - we should update the docs. They should mention when extends unknown is unnecessary, and include at least one or two examples in the code blocks. Accepting PRs!

Affected URL(s)

https://typescript-eslint.io/rules/no-unnecessary-type-constraint/
@JoshuaKGoldberg JoshuaKGoldberg added good first issue Good for newcomers package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin documentation Documentation ("docs") that needs adding/updating accepting prs Go ahead, send a pull request that resolves this issue labels Apr 29, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Apr 29, 2023
Merged
1 task
@takanome-dev
Copy link
Contributor

Time to learn more about eslint/ts-eslint rules 🔥, let me give it a a shot 🔫

@takanome-dev takanome-dev mentioned this issue Apr 30, 2023
Merged
3 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepting prs Go ahead, send a pull request that resolves this issue documentation Documentation ("docs") that needs adding/updating good first issue Good for newcomers package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
Projects
None yet
Milestone
No milestone
2 participants
@JoshuaKGoldberg @takanome-dev