Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(type-utils): make isTypeReadonly's options param optional #4415

Merged
merged 1 commit into from Jan 11, 2022

Conversation

RebeccaStevens
Copy link
Contributor

PR Checklist

Overview

Use the default options as the default param.

@nx-cloud
Copy link

nx-cloud bot commented Jan 9, 2022

☁️ Nx Cloud Report

CI ran the following commands for commit 974858a. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 48 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @RebeccaStevens!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Jan 9, 2022

✔️ Deploy Preview for typescript-eslint ready!

🔨 Explore the source changes: 974858a

🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/61da7c5a8e31750007f7cb0d

😎 Browse the preview: https://deploy-preview-4415--typescript-eslint.netlify.app

@codecov
Copy link

codecov bot commented Jan 9, 2022

Codecov Report

Merging #4415 (974858a) into main (97c0e86) will increase coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #4415      +/-   ##
==========================================
+ Coverage   91.95%   91.97%   +0.02%     
==========================================
  Files         346      161     -185     
  Lines       11622     8125    -3497     
  Branches     3298     2599     -699     
==========================================
- Hits        10687     7473    -3214     
+ Misses        675      460     -215     
+ Partials      260      192      -68     
Flag Coverage Δ
unittest 91.97% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/type-utils/src/isTypeReadonly.ts 0.00% <0.00%> (ø)
packages/scope-manager/src/scope/FunctionScope.ts
...ope-manager/src/definition/TSEnumNameDefinition.ts
packages/experimental-utils/src/ast-utils/index.ts
...utils/src/ast-utils/eslint-utils/PatternMatcher.ts
packages/scope-manager/src/ScopeManager.ts
...ages/scope-manager/src/referencer/ExportVisitor.ts
packages/scope-manager/src/lib/lib.ts
...perimental-utils/src/ts-eslint-scope/Referencer.ts
packages/scope-manager/src/lib/es2018.regexp.ts
... and 176 more

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, thanks!

@JoshuaKGoldberg JoshuaKGoldberg enabled auto-merge (squash) January 9, 2022 23:25
@JoshuaKGoldberg
Copy link
Member

JoshuaKGoldberg commented Jan 9, 2022

I'm surprised a 0% diff is marked as a blocker for codecov... I'll investigate a bit more if #4418 isn't merged soon.

@bradzacher bradzacher added the enhancement New feature or request label Jan 11, 2022
@bradzacher bradzacher changed the title fix(type-utils): make isTypeReadonly's options param optional feat(type-utils): make isTypeReadonly's options param optional Jan 11, 2022
@bradzacher bradzacher changed the title feat(type-utils): make isTypeReadonly's options param optional fix(type-utils): make isTypeReadonly's options param optional Jan 11, 2022
@bradzacher bradzacher changed the title fix(type-utils): make isTypeReadonly's options param optional feat(type-utils): make isTypeReadonly's options param optional Jan 11, 2022
@bradzacher bradzacher merged commit 3a07a56 into typescript-eslint:main Jan 11, 2022
@RebeccaStevens RebeccaStevens deleted the issue-4410 branch January 11, 2022 07:56
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[isTypeReadonly] options parameter should be optional
3 participants