New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(type-utils): make isTypeReadonly's options param optional #4415
Conversation
Thanks for the PR, @RebeccaStevens! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
✔️ Deploy Preview for typescript-eslint ready! 🔨 Explore the source changes: 974858a 🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/61da7c5a8e31750007f7cb0d 😎 Browse the preview: https://deploy-preview-4415--typescript-eslint.netlify.app |
Codecov Report
@@ Coverage Diff @@
## main #4415 +/- ##
==========================================
+ Coverage 91.95% 91.97% +0.02%
==========================================
Files 346 161 -185
Lines 11622 8125 -3497
Branches 3298 2599 -699
==========================================
- Hits 10687 7473 -3214
+ Misses 675 460 -215
+ Partials 260 192 -68
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me, thanks!
I'm surprised a 0% diff is marked as a blocker for codecov... I'll investigate a bit more if #4418 isn't merged soon. |
PR Checklist
Overview
Use the default options as the default param.