[no-shadow] false positive for class static generics

[vmatyi]

• I have tried restarting my IDE and the issue persists.
• I have updated to the latest version of the packages.
• I have read the FAQ and my problem is not listed.

Repro

{
  "rules": {
    "no-shadow": "off",
    "@typescript-eslint/no-shadow": "warn",
  }
}

export class SomeClass<K> {
  static create<K>() {
    return new SomeClass<K>(); // warn: 'K' is already declared in the upper scope. eslint(@typescript-eslint/no-shadow)
  }
}

Expected Result

No ESLint errors about shadowed name.
The generic parameter of a class is not available in static functions, thus there is no real shadowing:

export class SomeClass<K> {
  static create() {
    return new SomeClass<K>();  // error: Static members cannot reference class type parameters. ts(2302)
  }
}

Renaming the static members will reduce readability, as the function and meaning of the generic parameter is the same.
The use case is very similar to a class member and a member function parameter, which is allowed, and rightly so:

export class OtherClass {
  name: string | undefined;
  setName(name: string) {
    this.name = name;
  }
}

This issue was mentioned as part of #2480 (2.), but I suspect it was overlooked.

Actual Result

'K' is already declared in the upper scope. eslint(@typescript-eslint/no-shadow)

Versions

package	version
@typescript-eslint/eslint-plugin-tslint	4.22.0
@typescript-eslint/parser	4.22.0
TypeScript	3.9.9
ESLint	7.24.0
node	12.19.1

[bradzacher]

Duplicate of #2592

Please use the search