Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated typescript eslint package #2056

Merged
merged 3 commits into from May 10, 2021
Merged

updated typescript eslint package #2056

merged 3 commits into from May 10, 2021

Conversation

alonstern
Copy link
Contributor

This is to add the rule [return-await] that was fixed in the latest typescript eslint version

Release Notes:
None

@alonstern alonstern requested a review from a team May 9, 2021 13:00
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.003%) to 94.57% when pulling 91e372d on alonstern:upgrade-typescript-eslint into 508e21b on salto-io:master.

ori-moisis
ori-moisis reviewed May 9, 2021
View reviewed changes
eslintrc.js Outdated Show resolved Hide resolved
eslintrc.js Outdated Show resolved Hide resolved
eslintrc.js Show resolved Hide resolved
packages/lowerdash/src/collections/tree_map.ts Show resolved Hide resolved
@ori-moisis
Copy link
Contributor

before we merge this we should consider the impact of it on the lazy elements branch, if we don't need it for something specific on master it might be better to make these changes directly on the lazy elements branch?

@alonstern alonstern changed the base branch from master to lazy_element_intg May 9, 2021 15:17
@alonstern alonstern changed the base branch from lazy_element_intg to master May 9, 2021 15:18
ori-moisis
ori-moisis reviewed May 9, 2021
View reviewed changes
eslintrc.js Outdated Show resolved Hide resolved
@alonstern alonstern changed the base branch from master to lazy_element_intg May 9, 2021 16:47
roironn
roironn approved these changes May 10, 2021
View reviewed changes
Copy link
Contributor

@roironn roironn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just verifying - this is just a result of running lint--fix right on the lazy branch right? No other edits?

If so - approved - and thanks for dodging the rebase hell it would have caused :)

@alonstern
Copy link
Contributor Author

Just verifying - this is just a result of running lint--fix right on the lazy branch right? No other edits?

If so - approved - and thanks for dodging the rebase hell it would have caused :)

I did fix things here manually, (mainly reordering definitions in files for the no-undef rule and adding some eslint-disable-next-line)

@alonstern alonstern merged commit 9b4a513 into salto-io:lazy_element_intg May 10, 2021
roironn pushed a commit to roironn/salto-1 that referenced this pull request May 20, 2021
@alonstern @roironn
updated typescript eslint package (salto-io#2056)
0b5f25a
roironn pushed a commit to roironn/salto-1 that referenced this pull request May 23, 2021
@alonstern @roironn
updated typescript eslint package (salto-io#2056)
b6a9432
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ori-moisis ori-moisis ori-moisis left review comments

@roironn roironn roironn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alonstern @coveralls @ori-moisis @roironn