chore: tag function

typescript-eslint · Apr 29, 2024 · ecd31e3 · ecd31e3
1 parent 171701b
commit ecd31e3
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 0 deletions.
diff --git a/packages/eslint-plugin/src/rules/no-floating-promises.ts b/packages/eslint-plugin/src/rules/no-floating-promises.ts
@@ -321,6 +321,15 @@ export default createRule<Options, MessageId>({
         // All other cases are unhandled.
         return { isUnhandled: true };
       } else if (node.type === AST_NODE_TYPES.TaggedTemplateExpression) {
+        if (
+          doesTypeMatchSpecifier(
+            services,
+            allowForKnownSafePromises,
+            services.getTypeAtLocation(node),
+          )
+        ) {
+          return { isUnhandled: false };
+        }
         return { isUnhandled: true };
       } else if (node.type === AST_NODE_TYPES.ConditionalExpression) {
         // We must be getting the promise-like value from one of the branches of the

diff --git a/packages/eslint-plugin/tests/rules/no-floating-promises.test.ts b/packages/eslint-plugin/tests/rules/no-floating-promises.test.ts
@@ -694,6 +694,16 @@ type Foo<T> = Promise<T> & { hey?: string };
     },
     {
       code: `
+type SafePromise = Promise<number> & { __linterBrands?: string };
+declare const myTag: (strings: TemplateStringsArray) => SafePromise;
+myTag\`abc\`;
+      `,
+      options: [
+        { allowForKnownSafePromises: [{ from: 'file', name: 'SafePromise' }] },
+      ],
+    },
+    {
+      code: `
 declare const myTag: (strings: TemplateStringsArray) => Promise<void>;
 myTag\`abc\`.catch(() => {});
       `,
@@ -2153,5 +2163,14 @@ type Foo<T> = Promise<T> & { hey?: string };
       options: [{ allowForKnownSafePromises: [{ from: 'file', name: 'Bar' }] }],
       errors: [{ line: 3, messageId: 'floatingPromiseArrayVoid' }],
     },
+    {
+      code: `
+type SafePromise = Promise<number> & { __linterBrands?: string };
+declare const myTag: (strings: TemplateStringsArray) => SafePromise;
+myTag\`abc\`;
+      `,
+      options: [{ allowForKnownSafePromises: [{ from: 'file', name: 'Foo' }] }],
+      errors: [{ line: 4, messageId: 'floatingVoid' }],
+    },
   ],
 });