fix(eslint-plugin): [no-unnecessary-type-assertion] handle assignment (…

…#3133)
typescript-eslint · Mar 8, 2021 · cb22561 · cb22561
1 parent 3f9e9a1
commit cb22561
Show file tree

Hide file tree

Showing 3 changed files with 67 additions and 0 deletions.
diff --git a/packages/eslint-plugin/src/rules/no-unnecessary-type-assertion.ts b/packages/eslint-plugin/src/rules/no-unnecessary-type-assertion.ts
@@ -135,7 +135,26 @@ export default util.createRule<Options, MessageIds>({
 
     return {
       TSNonNullExpression(node): void {
+        if (
+          node.parent?.type === AST_NODE_TYPES.AssignmentExpression &&
+          node.parent?.operator === '=' &&
+          node.parent.left === node
+        ) {
+          context.report({
+            node,
+            messageId: 'contextuallyUnnecessary',
+            fix(fixer) {
+              return fixer.removeRange([
+                node.expression.range[1],
+                node.range[1],
+              ]);
+            },
+          });
+          return;
+        }
+
         const originalNode = parserServices.esTreeNodeToTSNodeMap.get(node);
+
         const type = util.getConstrainedTypeAtLocation(
           checker,
           originalNode.expression,

diff --git a/packages/eslint-plugin/src/util/types.ts b/packages/eslint-plugin/src/util/types.ts
@@ -11,6 +11,7 @@ import {
   isVariableDeclaration,
   unionTypeParts,
   isPropertyAssignment,
+  isBinaryExpression,
 } from 'tsutils';
 import * as ts from 'typescript';
 
@@ -498,6 +499,13 @@ export function getContextualType(
     return checker.getContextualType(parent);
   } else if (isPropertyAssignment(parent) && isIdentifier(node)) {
     return checker.getContextualType(node);
+  } else if (
+    isBinaryExpression(parent) &&
+    parent.operatorToken.kind === ts.SyntaxKind.EqualsToken &&
+    parent.right === node
+  ) {
+    // is RHS of assignment
+    return checker.getTypeAtLocation(parent.left);
   } else if (
     ![ts.SyntaxKind.TemplateSpan, ts.SyntaxKind.JsxExpression].includes(
       parent.kind,

diff --git a/packages/eslint-plugin/tests/rules/no-unnecessary-type-assertion.test.ts b/packages/eslint-plugin/tests/rules/no-unnecessary-type-assertion.test.ts
@@ -186,6 +186,22 @@ const c = <const>[...a, ...b];
     {
       code: "const a = <const>{ foo: 'foo' };",
     },
+    {
+      code: `
+let a: number | undefined;
+let b: number | undefined;
+let c: number;
+a = b;
+c = b!;
+a! -= 1;
+      `,
+    },
+    {
+      code: `
+let a: { b?: string } | undefined;
+a!.b = '';
+      `,
+    },
   ],
 
   invalid: [
@@ -451,5 +467,29 @@ function Test(props: { id?: string | number }) {
       ],
       filename: 'react.tsx',
     },
+    {
+      code: `
+let x: number | undefined;
+let y: number | undefined;
+y = x!;
+y! = 0;
+      `,
+      output: `
+let x: number | undefined;
+let y: number | undefined;
+y = x;
+y = 0;
+      `,
+      errors: [
+        {
+          messageId: 'contextuallyUnnecessary',
+          line: 4,
+        },
+        {
+          messageId: 'contextuallyUnnecessary',
+          line: 5,
+        },
+      ],
+    },
   ],
 });