fix(eslint-plugin): [no-implied-eval] permit more expression types (#…

…3624)
typescript-eslint · Aug 1, 2021 · ca7c549 · ca7c549
1 parent 62bcc93
commit ca7c549
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 5 deletions.
diff --git a/packages/eslint-plugin/src/rules/no-implied-eval.ts b/packages/eslint-plugin/src/rules/no-implied-eval.ts
@@ -112,16 +112,15 @@ export default util.createRule({
         case AST_NODE_TYPES.FunctionExpression:
           return true;
 
-        case AST_NODE_TYPES.MemberExpression:
-        case AST_NODE_TYPES.Identifier:
-        case AST_NODE_TYPES.ConditionalExpression:
-          return isFunctionType(node);
+        case AST_NODE_TYPES.Literal:
+        case AST_NODE_TYPES.TemplateLiteral:
+          return false;
 
         case AST_NODE_TYPES.CallExpression:
           return isBind(node.callee) || isFunctionType(node);
 
         default:
-          return false;
+          return isFunctionType(node);
       }
     }
 

diff --git a/packages/eslint-plugin/tests/rules/no-implied-eval.test.ts b/packages/eslint-plugin/tests/rules/no-implied-eval.test.ts
@@ -256,6 +256,7 @@ const foo = () => {};
 const bar = () => {};
 
 setTimeout(Math.radom() > 0.5 ? foo : bar, 0);
+setTimeout(foo || bar, 500);
     `,
     `
 class Foo {
@@ -816,6 +817,21 @@ globalThis['execScript'](\`\`);
         },
       ],
     },
+    {
+      code: `
+const foo: string | undefined = 'hello';
+const bar = () => {};
+
+setTimeout(foo || bar, 500);
+      `,
+      errors: [
+        {
+          messageId: 'noImpliedEvalError',
+          line: 5,
+          column: 12,
+        },
+      ],
+    },
     {
       code: 'const fn = Function();',
       errors: [