Skip to content

Commit

Permalink
fix for review
Browse files Browse the repository at this point in the history
  • Loading branch information
mysticatea committed Apr 9, 2019
1 parent 081a338 commit 872ed49
Showing 1 changed file with 4 additions and 6 deletions.
Expand Up @@ -367,11 +367,10 @@ export default createRule({
// foo.charAt(0) === "a"
// foo[foo.length - 1] === "a"
// foo.charAt(foo.length - 1) === "a"
// @ts-ignore
[[
[String([
'BinaryExpression > MemberExpression.left[computed=true]',
'BinaryExpression > CallExpression.left > MemberExpression.callee[property.name="charAt"][computed=false]',
]](node: TSESTree.MemberExpression): void {
])](node: TSESTree.MemberExpression): void {
let parentNode = node.parent!;
let indexNode: TSESTree.Node | null = null;
if (parentNode.type === 'CallExpression') {
Expand Down Expand Up @@ -532,11 +531,10 @@ export default createRule({
// foo.substring(0, 3) === 'bar'
// foo.substring(foo.length - 3) === 'bar'
// foo.substring(foo.length - 3, foo.length) === 'bar'
// @ts-ignore
[[
[String([
'CallExpression > MemberExpression.callee[property.name=slice][computed=false]',
'CallExpression > MemberExpression.callee[property.name=substring][computed=false]',
]](node: TSESTree.MemberExpression): void {
])](node: TSESTree.MemberExpression): void {
const callNode = node.parent! as TSESTree.CallExpression;
const parentNode = callNode.parent!;
if (
Expand Down

0 comments on commit 872ed49

Please sign in to comment.