fix(typescript-estree): support private optional property definition (#…

…3997) * fix(typescript-estree): support private optional property definition * test: add more test
typescript-eslint · Oct 14, 2021 · 8605e08 · 8605e08
1 parent 154ec9a
commit 8605e08
Show file tree

Hide file tree

Showing 4 changed files with 699 additions and 1 deletion.
diff --git a/...es/shared-fixtures/fixtures/typescript/basics/class-with-private-optional-property.src.ts b/...es/shared-fixtures/fixtures/typescript/basics/class-with-private-optional-property.src.ts
@@ -0,0 +1,5 @@
+class Foo {
+  #prop?: string;
+  #propExplicitWithValue?: string = '';
+  #propImplicitWithValue? = '';
+}
diff --git a/packages/typescript-estree/src/convert.ts b/packages/typescript-estree/src/convert.ts
@@ -1149,7 +1149,8 @@ export class Converter {
 
         if (
           (node.name.kind === SyntaxKind.Identifier ||
-            node.name.kind === SyntaxKind.ComputedPropertyName) &&
+            node.name.kind === SyntaxKind.ComputedPropertyName ||
+            node.name.kind === SyntaxKind.PrivateIdentifier) &&
           node.questionToken
         ) {
           result.optional = true;

diff --git a/packages/typescript-estree/tests/lib/__snapshots__/semantic-diagnostics-enabled.test.ts.snap b/packages/typescript-estree/tests/lib/__snapshots__/semantic-diagnostics-enabled.test.ts.snap
@@ -1835,6 +1835,8 @@ exports[`Parse all fixtures with "errorOnTypeScriptSyntacticAndSemanticIssues" e
 
 exports[`Parse all fixtures with "errorOnTypeScriptSyntacticAndSemanticIssues" enabled fixtures/typescript/basics/class-with-override-property.src 1`] = `"TEST OUTPUT: No semantic or syntactic issues found"`;
 
+exports[`Parse all fixtures with "errorOnTypeScriptSyntacticAndSemanticIssues" enabled fixtures/typescript/basics/class-with-private-optional-property.src 1`] = `"TEST OUTPUT: No semantic or syntactic issues found"`;
+
 exports[`Parse all fixtures with "errorOnTypeScriptSyntacticAndSemanticIssues" enabled fixtures/typescript/basics/class-with-private-parameter-properties.src 1`] = `"TEST OUTPUT: No semantic or syntactic issues found"`;
 
 exports[`Parse all fixtures with "errorOnTypeScriptSyntacticAndSemanticIssues" enabled fixtures/typescript/basics/class-with-property-function.src 1`] = `"TEST OUTPUT: No semantic or syntactic issues found"`;