Update packages/eslint-plugin/src/rules/no-this-alias.ts

Co-authored-by: Josh Goldberg <me@joshuakgoldberg.com>
typescript-eslint · Mar 26, 2022 · 84cef31 · 84cef31
1 parent 874037a
commit 84cef31
Showing 1 changed file with 2 additions and 7 deletions.
diff --git a/packages/eslint-plugin/src/rules/no-this-alias.ts b/packages/eslint-plugin/src/rules/no-this-alias.ts
@@ -51,13 +51,8 @@ export default util.createRule<Options, MessageIds>({
       "VariableDeclarator[init.type='ThisExpression'], AssignmentExpression[right.type='ThisExpression']"(
         node: TSESTree.VariableDeclarator | TSESTree.AssignmentExpression,
       ): void {
-        let id;
-
-        if (node.type === AST_NODE_TYPES.VariableDeclarator) {
-          id = node.id;
-        } else {
-          id = node.left;
-        }
+        const id =
+          node.type === AST_NODE_TYPES.VariableDeclarator ? node.id : node.left;
         if (allowDestructuring && id.type !== AST_NODE_TYPES.Identifier) {
           return;
         }