fix(utils): support immutable arrays in ReportFixFunction (#3830)

typescript-eslint · Sep 3, 2021 · 8218055 · 8218055
1 parent e59a17c
commit 8218055
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 7 deletions.
diff --git a/packages/eslint-plugin/src/rules/no-explicit-any.ts b/packages/eslint-plugin/src/rules/no-explicit-any.ts
@@ -1,9 +1,9 @@
 import {
-  TSESTree,
   AST_NODE_TYPES,
+  TSESLint,
+  TSESTree,
 } from '@typescript-eslint/experimental-utils';
 import * as util from '../util';
-import { TSESLint } from '@typescript-eslint/experimental-utils';
 
 export type Options = [
   {
@@ -199,8 +199,8 @@ export default util.createRule<Options, MessageIds>({
         };
 
         if (fixToUnknown) {
-          fixOrSuggest.fix = (fixer =>
-            fixer.replaceText(node, 'unknown')) as TSESLint.ReportFixFunction;
+          fixOrSuggest.fix = (fixer): TSESLint.RuleFix =>
+            fixer.replaceText(node, 'unknown');
         }
 
         context.report({

diff --git a/packages/eslint-plugin/src/rules/prefer-enum-initializers.ts b/packages/eslint-plugin/src/rules/prefer-enum-initializers.ts
@@ -1,6 +1,5 @@
-import { TSESTree } from '@typescript-eslint/experimental-utils';
+import { TSESLint, TSESTree } from '@typescript-eslint/experimental-utils';
 import * as util from '../util';
-import { TSESLint } from '@typescript-eslint/experimental-utils';
 
 type MessageIds = 'defineInitializer' | 'defineInitializerSuggestion';
 

diff --git a/packages/experimental-utils/src/ts-eslint/Rule.ts b/packages/experimental-utils/src/ts-eslint/Rule.ts
@@ -114,7 +114,7 @@ interface RuleFixer {
 
 type ReportFixFunction = (
   fixer: RuleFixer,
-) => null | RuleFix | RuleFix[] | IterableIterator<RuleFix>;
+) => null | RuleFix | readonly RuleFix[] | IterableIterator<RuleFix>;
 type ReportSuggestionArray<TMessageIds extends string> =
   ReportDescriptorBase<TMessageIds>[];