fix(eslint-plugin): make sorting order consistent

typescript-eslint · Dec 21, 2020 · 77c36ce · 77c36ce
1 parent 5fd2fcb
commit 77c36ce
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/packages/eslint-plugin/src/rules/naming-convention-utils/validator.ts b/packages/eslint-plugin/src/rules/naming-convention-utils/validator.ts
@@ -53,11 +53,14 @@ function createValidator(
         return -1;
       }
 
+      const aIsMethodOrProperty = isMethodOrPropertySelector(a.selector);
+      const bIsMethodOrProperty = isMethodOrPropertySelector(b.selector);
+
       // for backward compatibility, method and property have higher precedence than other meta selectors
-      if (isMethodOrPropertySelector(a.selector)) {
+      if (aIsMethodOrProperty && !bIsMethodOrProperty) {
         return -1;
       }
-      if (isMethodOrPropertySelector(b.selector)) {
+      if (!aIsMethodOrProperty && bIsMethodOrProperty) {
         return 1;
       }