fix(eslint-plugin): [no-var-requires] report when used in type assert…

…ion (#3074)
typescript-eslint · Feb 19, 2021 · 763a252 · 763a252
1 parent 1bd8f4e
commit 763a252
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/packages/eslint-plugin/src/rules/no-var-requires.ts b/packages/eslint-plugin/src/rules/no-var-requires.ts
@@ -37,6 +37,7 @@ export default util.createRule<Options, MessageIds>({
           (parent.type === AST_NODE_TYPES.VariableDeclarator ||
             parent.type === AST_NODE_TYPES.CallExpression ||
             parent.type === AST_NODE_TYPES.TSAsExpression ||
+            parent.type === AST_NODE_TYPES.TSTypeAssertion ||
             parent.type === AST_NODE_TYPES.MemberExpression)
         ) {
           context.report({

diff --git a/packages/eslint-plugin/tests/rules/no-var-requires.test.ts b/packages/eslint-plugin/tests/rules/no-var-requires.test.ts
@@ -112,6 +112,16 @@ ruleTester.run('no-var-requires', rule, {
         },
       ],
     },
+    {
+      code: "const foo = <Foo>require('./foo.json');",
+      errors: [
+        {
+          messageId: 'noVarReqs',
+          line: 1,
+          column: 18,
+        },
+      ],
+    },
     {
       code: "const foo: Foo = require('./foo.json').default;",
       errors: [