fix(eslint-plugin): [comma-spacing] handle empty type params (#2915)

typescript-eslint · Jan 3, 2021 · 4d69fbb · 4d69fbb
1 parent 85c2720
commit 4d69fbb
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/packages/eslint-plugin/src/rules/comma-spacing.ts b/packages/eslint-plugin/src/rules/comma-spacing.ts
@@ -90,10 +90,13 @@ export default createRule<Options, MessageIds>({
     function addTypeParametersTrailingCommaToIgnoreList(
       node: TSESTree.TSTypeParameterDeclaration,
     ): void {
-      const param = node.params[node.params.length - 1];
-      const afterToken = sourceCode.getTokenAfter(param);
-      if (afterToken && isCommaToken(afterToken)) {
-        ignoredTokens.add(afterToken);
+      const paramLength = node.params.length;
+      if (paramLength) {
+        const param = node.params[paramLength - 1];
+        const afterToken = sourceCode.getTokenAfter(param);
+        if (afterToken && isCommaToken(afterToken)) {
+          ignoredTokens.add(afterToken);
+        }
       }
     }
 

diff --git a/packages/eslint-plugin/tests/rules/comma-spacing.test.ts b/packages/eslint-plugin/tests/rules/comma-spacing.test.ts
@@ -280,6 +280,7 @@ ruleTester.run('comma-spacing', rule, {
     'function foo<T,>() {}',
     'class Foo<T, T1> {}',
     'interface Foo<T, T1,>{}',
+    'interface A<> {}',
   ],
 
   invalid: [