chore: more test coverage; I'd missed a couple of keywords

typescript-eslint · Feb 2, 2022 · 3c1c524 · 3c1c524
1 parent 9742e45
commit 3c1c524
Show file tree

Hide file tree

Showing 2 changed files with 36 additions and 3 deletions.
diff --git a/packages/eslint-plugin/src/rules/no-redundant-type-constituents.ts b/packages/eslint-plugin/src/rules/no-redundant-type-constituents.ts
@@ -44,6 +44,8 @@ const keywordNodeTypesToTsTypes = new Map([
   [TSESTree.AST_NODE_TYPES.TSAnyKeyword, ts.TypeFlags.Any],
   [TSESTree.AST_NODE_TYPES.TSBigIntKeyword, ts.TypeFlags.BigInt],
   [TSESTree.AST_NODE_TYPES.TSBooleanKeyword, ts.TypeFlags.Boolean],
+  [TSESTree.AST_NODE_TYPES.TSNeverKeyword, ts.TypeFlags.Never],
+  [TSESTree.AST_NODE_TYPES.TSUnknownKeyword, ts.TypeFlags.Unknown],
   [TSESTree.AST_NODE_TYPES.TSNumberKeyword, ts.TypeFlags.Number],
   [TSESTree.AST_NODE_TYPES.TSStringKeyword, ts.TypeFlags.String],
 ]);

diff --git a/packages/eslint-plugin/tests/rules/no-redundant-type-constituents.test.ts b/packages/eslint-plugin/tests/rules/no-redundant-type-constituents.test.ts
@@ -13,8 +13,19 @@ const ruleTester = new RuleTester({
 
 ruleTester.run('no-redundant-type-constituents', rule, {
   valid: [
-    'type T = any;',
-    'type T = never;',
+    `
+      type T = any;
+      type U = T;
+    `,
+    `
+      type T = never;
+      type U = T;
+    `,
+    `
+      type T = 1 | 2;
+      type U = T | 3;
+      type V = U;
+    `,
     'type T = () => never;',
     'type T = () => never | string;',
     `
@@ -36,7 +47,6 @@ ruleTester.run('no-redundant-type-constituents', rule, {
       type B = never;
       type T = { new (): string | B };
     `,
-    'type T = unknown;',
     `
       type B = unknown;
       type T = B;
@@ -134,6 +144,11 @@ ruleTester.run('no-redundant-type-constituents', rule, {
       type B = string;
       type T = B & null;
     `,
+    'type T = `${string}` & null;',
+    `
+      type B = \`\${string}\`;
+      type T = B & null;
+    `,
   ],
 
   invalid: [
@@ -224,6 +239,22 @@ ruleTester.run('no-redundant-type-constituents', rule, {
         },
       ],
     },
+    {
+      code: `
+        type B = never;
+        type T = B | number;
+      `,
+      errors: [
+        {
+          column: 18,
+          data: {
+            container: 'union',
+            typeName: 'never',
+          },
+          messageId: 'overridden',
+        },
+      ],
+    },
     {
       code: 'type T = never | number;',
       errors: [