fix: add missing type check to no-unused-vars

typescript-eslint · Feb 21, 2021 · 34b9d6a · 34b9d6a
1 parent fe74a6f
commit 34b9d6a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/packages/eslint-plugin/src/rules/no-unused-vars.ts b/packages/eslint-plugin/src/rules/no-unused-vars.ts
@@ -408,10 +408,12 @@ export default util.createRule<Options, MessageIds>({
         return cached;
       }
 
-      for (const statement of node.body?.body ?? []) {
-        if (statement.type === AST_NODE_TYPES.TSExportAssignment) {
-          MODULE_DECL_CACHE.set(node, true);
-          return true;
+      if (node.body && node.body.type !== AST_NODE_TYPES.TSModuleDeclaration) {
+        for (const statement of node.body.body ?? []) {
+          if (statement.type === AST_NODE_TYPES.TSExportAssignment) {
+            MODULE_DECL_CACHE.set(node, true);
+            return true;
+          }
         }
       }
 

diff --git a/packages/typescript-estree/src/convert.ts b/packages/typescript-estree/src/convert.ts
@@ -1932,7 +1932,7 @@ export class Converter {
       }
 
       case SyntaxKind.NumericLiteral: {
-        return this.createNode<TSESTree.NumericLiteral>(node, {
+        return this.createNode<TSESTree.NumberLiteral>(node, {
           type: AST_NODE_TYPES.Literal,
           value: Number(node.text),
           raw: node.getText(),