fix(eslint-plugin): [no-type-alias] consider keyof as an alias (#3242)

typescript-eslint · Mar 29, 2021 · 329ef02 · 329ef02
1 parent 265a039
commit 329ef02
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/packages/eslint-plugin/src/rules/no-type-alias.ts b/packages/eslint-plugin/src/rules/no-type-alias.ts
@@ -264,9 +264,10 @@ export default util.createRule<Options, MessageIds>({
         type.node.type.endsWith('Keyword') ||
         aliasTypes.has(type.node.type) ||
         (type.node.type === AST_NODE_TYPES.TSTypeOperator &&
-          type.node.operator === 'readonly' &&
-          type.node.typeAnnotation &&
-          aliasTypes.has(type.node.typeAnnotation.type))
+          (type.node.operator === 'keyof' ||
+            (type.node.operator === 'readonly' &&
+              type.node.typeAnnotation &&
+              aliasTypes.has(type.node.typeAnnotation.type))))
       ) {
         // alias / keyword
         checkAndReport(allowAliases!, isTopLevel, type, 'Aliases');

diff --git a/packages/eslint-plugin/tests/rules/no-type-alias.test.ts b/packages/eslint-plugin/tests/rules/no-type-alias.test.ts
@@ -394,6 +394,13 @@ export type ClassValue =
       code: 'type Foo = typeof bar;',
       options: [{ allowAliases: 'always' }],
     },
+    {
+      code: `
+const WithAKey = { AKey: true };
+type KeyNames = keyof typeof SCALARS;
+      `,
+      options: [{ allowAliases: 'always' }],
+    },
     {
       code: 'type Foo = typeof bar | typeof baz;',
       options: [{ allowAliases: 'in-unions' }],