fix(eslint-plugin): [promise-function-async] allow any as return value

typescript-eslint · May 24, 2019 · 328ea7f · 328ea7f
1 parent cca1714
commit 328ea7f
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/packages/eslint-plugin/src/rules/promise-function-async.ts b/packages/eslint-plugin/src/rules/promise-function-async.ts
@@ -1,3 +1,5 @@
+import ts from 'typescript';
+import { isTypeFlagSet } from 'tsutils';
 import { TSESTree } from '@typescript-eslint/experimental-utils';
 import * as util from '../util';
 
@@ -90,6 +92,9 @@ export default util.createRule<Options, MessageIds>({
       }
       const returnType = checker.getReturnTypeOfSignature(signatures[0]);
 
+      if (isTypeFlagSet(returnType, ts.TypeFlags.Any | ts.TypeFlags.Unknown)) {
+        return;
+      }
       if (!util.containsTypeByName(returnType, allAllowedPromiseNames)) {
         return;
       }

diff --git a/packages/eslint-plugin/tests/rules/promise-function-async.test.ts b/packages/eslint-plugin/tests/rules/promise-function-async.test.ts
@@ -16,6 +16,16 @@ const ruleTester = new RuleTester({
 ruleTester.run('promise-function-async', rule, {
   valid: [
     `
+function returnsAny(): any {
+  return 1;
+}
+    `,
+    `
+function returnsUnknown(): unknown {
+  return 1;
+}
+    `,
+    `
 const nonAsyncNonPromiseArrowFunction = (n: number) => n;
     `,
     `