Apply suggestions from code review

Co-authored-by: Josh Goldberg <me@joshuakgoldberg.com>
typescript-eslint · Oct 17, 2021 · 2b00d98 · 2b00d98
1 parent fbbb87f
commit 2b00d98
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/packages/eslint-plugin/src/rules/no-shadow.ts b/packages/eslint-plugin/src/rules/no-shadow.ts
@@ -237,8 +237,7 @@ export default util.createRule<Options, MessageIds>({
       node: TSESTree.Node | null,
     ): node is TSESTree.StringLiteral {
       return (
-        !!node &&
-        node.type === AST_NODE_TYPES.Literal &&
+        node?.type === AST_NODE_TYPES.Literal &&
         typeof node.value === 'string'
       );
     }
@@ -266,7 +265,6 @@ export default util.createRule<Options, MessageIds>({
       return (
         isTypeImport(firstDefinition) &&
         isImportDeclaration(firstDefinition.parent) &&
-        isStringLiteral(firstDefinition.parent.source) &&
         isExternalModuleDeclarationWithName(
           scope,
           firstDefinition.parent.source.value,