Merge branch 'master' into this-type

typescript-eslint · May 16, 2021 · 2631fb3 · 2631fb3
2 parents 3905413 + cae4f4a
commit 2631fb3
Show file tree

Hide file tree

Showing 329 changed files with 4,513 additions and 2,208 deletions.
diff --git a/.all-contributorsrc b/.all-contributorsrc
@@ -58,6 +58,13 @@
       "profile": "https://github.com/G-Rath",
       "contributions": []
     },
+    {
+      "login": "JoshuaKGoldberg",
+      "name": "Josh Goldberg",
+      "avatar_url": "https://avatars.githubusercontent.com/u/3335181?v=4",
+      "profile": "https://github.com/JoshuaKGoldberg",
+      "contributions": []
+    },
     {
       "login": "nzakas",
       "name": "Nicholas C. Zakas",
@@ -73,10 +80,10 @@
       "contributions": []
     },
     {
-      "login": "JoshuaKGoldberg",
-      "name": "Josh Goldberg",
-      "avatar_url": "https://avatars.githubusercontent.com/u/3335181?v=4",
-      "profile": "https://github.com/JoshuaKGoldberg",
+      "login": "yeonjuan",
+      "name": "YeonJuan",
+      "avatar_url": "https://avatars.githubusercontent.com/u/41323220?v=4",
+      "profile": "https://github.com/yeonjuan",
       "contributions": []
     },
     {
@@ -87,10 +94,10 @@
       "contributions": []
     },
     {
-      "login": "yeonjuan",
-      "name": "YeonJuan",
-      "avatar_url": "https://avatars.githubusercontent.com/u/41323220?v=4",
-      "profile": "https://github.com/yeonjuan",
+      "login": "phaux",
+      "name": "Nikita Stefaniak",
+      "avatar_url": "https://avatars.githubusercontent.com/u/1270987?v=4",
+      "profile": "https://github.com/phaux",
       "contributions": []
     },
     {
@@ -135,13 +142,6 @@
       "profile": "https://github.com/mysticatea",
       "contributions": []
     },
-    {
-      "login": "phaux",
-      "name": "Nikita Stefaniak",
-      "avatar_url": "https://avatars.githubusercontent.com/u/1270987?v=4",
-      "profile": "https://github.com/phaux",
-      "contributions": []
-    },
     {
       "login": "azz",
       "name": "Lucas Azzola",
@@ -170,6 +170,13 @@
       "profile": "https://github.com/macklinu",
       "contributions": []
     },
+    {
+      "login": "JounQin",
+      "name": "JounQin",
+      "avatar_url": "https://avatars.githubusercontent.com/u/8336744?v=4",
+      "profile": "https://github.com/JounQin",
+      "contributions": []
+    },
     {
       "login": "lukyth",
       "name": "Kanitkorn Sujautra",
@@ -207,7 +214,7 @@
     },
     {
       "login": "ldrick",
-      "name": "Ricky Lippmann",
+      "name": "ldrick",
       "avatar_url": "https://avatars.githubusercontent.com/u/3674067?v=4",
       "profile": "https://github.com/ldrick",
       "contributions": []
@@ -352,6 +359,20 @@
       "profile": "https://github.com/timkraut",
       "contributions": []
     },
+    {
+      "login": "magurotuna",
+      "name": "Yusuke Tanaka",
+      "avatar_url": "https://avatars.githubusercontent.com/u/23649474?v=4",
+      "profile": "https://github.com/magurotuna",
+      "contributions": []
+    },
+    {
+      "login": "Zzzen",
+      "name": "Zzzen",
+      "avatar_url": "https://avatars.githubusercontent.com/u/6630042?v=4",
+      "profile": "https://github.com/Zzzen",
+      "contributions": []
+    },
     {
       "login": "koooge",
       "name": "koooge",

diff --git a/.eslintignore b/.eslintignore
@@ -7,3 +7,6 @@ coverage
 __snapshots__
 
 packages/eslint-plugin-tslint/tests
+
+# Files copied as part of the build
+packages/types/src/ast-spec.ts
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -7,6 +7,7 @@ module.exports = {
     'import',
     'eslint-comments',
     '@typescript-eslint/internal',
+    'simple-import-sort',
   ],
   env: {
     es6: true,
@@ -64,7 +65,6 @@ module.exports = {
 
     // TODO - enable these new recommended rules
     '@typescript-eslint/no-unsafe-assignment': 'off',
-    '@typescript-eslint/no-unsafe-call': 'off',
     '@typescript-eslint/no-unsafe-member-access': 'off',
     '@typescript-eslint/no-unsafe-return': 'off',
     '@typescript-eslint/restrict-template-expressions': 'off',
@@ -191,6 +191,8 @@ module.exports = {
     {
       files: ['tests/**/*.js'],
       rules: {
+        '@typescript-eslint/explicit-function-return-type': 'off',
+        '@typescript-eslint/no-unsafe-call': 'off',
         '@typescript-eslint/restrict-plus-operands': 'off',
       },
     },
@@ -260,5 +262,27 @@ module.exports = {
         '@typescript-eslint/internal/prefer-ast-types-enum': 'off',
       },
     },
+    // ast spec specific standardization
+    {
+      files: ['packages/ast-spec/src/**/*.ts'],
+      rules: {
+        '@typescript-eslint/consistent-type-imports': [
+          'error',
+          { prefer: 'type-imports', disallowTypeAnnotations: true },
+        ],
+        '@typescript-eslint/no-unused-vars': 'error',
+        '@typescript-eslint/sort-type-union-intersection-members': 'error',
+        'import/first': 'error',
+        'import/newline-after-import': 'error',
+        'import/no-duplicates': 'error',
+        'simple-import-sort/imports': 'error',
+      },
+    },
+    {
+      files: ['rollup.config.ts'],
+      rules: {
+        'import/no-default-export': 'off',
+      },
+    },
   ],
 };
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -32,7 +32,7 @@ jobs:
         id: yarn-cache-dir-path
         run: echo "::set-output name=dir::$(yarn cache dir)"
 
-      - uses: actions/cache@v1
+      - uses: actions/cache@v2
         id: yarn-cache # use this to check for `cache-hit` (`steps.yarn-cache.outputs.cache-hit != 'true'`)
         with:
           path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
@@ -74,7 +74,7 @@ jobs:
         id: yarn-cache-dir-path
         run: echo "::set-output name=dir::$(yarn cache dir)"
 
-      - uses: actions/cache@v1
+      - uses: actions/cache@v2
         id: yarn-cache # use this to check for `cache-hit` (`steps.yarn-cache.outputs.cache-hit != 'true'`)
         with:
           path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
@@ -160,7 +160,7 @@ jobs:
         id: yarn-cache-dir-path
         run: echo "::set-output name=dir::$(yarn cache dir)"
 
-      - uses: actions/cache@v1
+      - uses: actions/cache@v2
         id: yarn-cache # use this to check for `cache-hit` (`steps.yarn-cache.outputs.cache-hit != 'true'`)
         with:
           path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
@@ -203,7 +203,7 @@ jobs:
         id: yarn-cache-dir-path
         run: echo "::set-output name=dir::$(yarn cache dir)"
 
-      - uses: actions/cache@v1
+      - uses: actions/cache@v2
         id: yarn-cache # use this to check for `cache-hit` (`steps.yarn-cache.outputs.cache-hit != 'true'`)
         with:
           path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
@@ -242,7 +242,7 @@ jobs:
         id: yarn-cache-dir-path
         run: echo "::set-output name=dir::$(yarn cache dir)"
 
-      - uses: actions/cache@v1
+      - uses: actions/cache@v2
         id: yarn-cache # use this to check for `cache-hit` (`steps.yarn-cache.outputs.cache-hit != 'true'`)
         with:
           path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
@@ -324,7 +324,7 @@ jobs:
         id: yarn-cache-dir-path
         run: echo "::set-output name=dir::$(yarn cache dir)"
 
-      - uses: actions/cache@v1
+      - uses: actions/cache@v2
         id: yarn-cache # use this to check for `cache-hit` (`steps.yarn-cache.outputs.cache-hit != 'true'`)
         with:
           path: ${{ steps.yarn-cache-dir-path.outputs.dir }}

diff --git a/.github/workflows/generate-contributors.yml b/.github/workflows/generate-contributors.yml
@@ -37,13 +37,14 @@ jobs:
       - name: Generate contributors
         run: yarn generate:contributors
 
-      - name: Commit files
-        run: |
-          git config --local user.email "actions@github.com"
-          git config --local user.name "Github Actions"
-          git commit -am "chore: update contributors [bot]"
-
-      - name: Push changes
-        uses: ad-m/github-push-action@master
+      - name: Create Pull Request
+        uses: peter-evans/create-pull-request@v3
         with:
-          github_token: ${{ secrets.GITHUB_TOKEN }}
+          # The standard GITHUB_TOKEN cannot be used as it will not trigger status checks on
+          # the PR that gets created (this behavior is not specific to this action).
+          # https://github.com/peter-evans/create-pull-request/blob/master/docs/concepts-guidelines.md#triggering-further-workflow-runs
+          token: ${{ secrets.JAMES_HENRY_GH_TOKEN }}
+          commit-message: "chore: update contributors"
+          title: "chore: update contributors"
+          body: ""
+          branch: auto-update-contributors
diff --git a/.github/workflows/manual-release.yml b/.github/workflows/manual-release.yml
diff --git a/.gitignore b/.gitignore
@@ -67,3 +67,7 @@ dist
 _ts3.4
 *.tsbuildinfo
 .watchmanconfig
+.rollup.cache
+
+# Files copied as part of the build
+packages/types/src/ast-spec.ts
diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -13,8 +13,8 @@
 
   // typescript auto-format settings
   "typescript.tsdk": "node_modules/typescript/lib",
-  "javascript.preferences.importModuleSpecifier": "auto",
-  "typescript.preferences.importModuleSpecifier": "auto",
+  "javascript.preferences.importModuleSpecifier": "project-relative",
+  "typescript.preferences.importModuleSpecifier": "project-relative",
   "javascript.preferences.quoteStyle": "single",
   "typescript.preferences.quoteStyle": "single",
   "editor.defaultFormatter": "esbenp.prettier-vscode",

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,31 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# [4.23.0](https://github.com/typescript-eslint/typescript-eslint/compare/v4.22.1...v4.23.0) (2021-05-10)
+
+
+### Bug Fixes
+
+* **scope-manager:** fix visiting TSAsExpression in assignment ([#3355](https://github.com/typescript-eslint/typescript-eslint/issues/3355)) ([87521a0](https://github.com/typescript-eslint/typescript-eslint/commit/87521a024103bc5fc643861649bee9a288f55b7b))
+
+
+### Features
+
+* **experimental-utils:** Include `getCwd()` in `RuleContext` type ([#3308](https://github.com/typescript-eslint/typescript-eslint/issues/3308)) ([2b75c11](https://github.com/typescript-eslint/typescript-eslint/commit/2b75c11d69bee88ca0cb77d7efd32b8d0387e6b3))
+* refactor to split AST specification out as its own module ([#2911](https://github.com/typescript-eslint/typescript-eslint/issues/2911)) ([25ea953](https://github.com/typescript-eslint/typescript-eslint/commit/25ea953cc60b118bd385c71e0a9b61c286c26fcf))
+
+
+
+
+
+## [4.22.1](https://github.com/typescript-eslint/typescript-eslint/compare/v4.22.0...v4.22.1) (2021-05-04)
+
+**Note:** Version bump only for package @typescript-eslint/typescript-eslint
+
+
+
+
+
 # [4.22.0](https://github.com/typescript-eslint/typescript-eslint/compare/v4.21.0...v4.22.0) (2021-04-12)