fix(eslint-plugin): [padding-line-between-statements] problems within…

… namespaces not being reported
typescript-eslint · Sep 12, 2021 · 0d58a24 · 0d58a24
1 parent 4a88de2
commit 0d58a24
Show file tree

Hide file tree

Showing 2 changed files with 42 additions and 1 deletion.
diff --git a/packages/eslint-plugin/src/rules/padding-line-between-statements.ts b/packages/eslint-plugin/src/rules/padding-line-between-statements.ts
@@ -723,10 +723,11 @@ export default util.createRule<Options, MessageIds>({
       if (
         !node.parent ||
         ![
-          AST_NODE_TYPES.SwitchStatement,
           AST_NODE_TYPES.BlockStatement,
           AST_NODE_TYPES.Program,
           AST_NODE_TYPES.SwitchCase,
+          AST_NODE_TYPES.SwitchStatement,
+          AST_NODE_TYPES.TSModuleBlock,
         ].includes(node.parent.type)
       ) {
         return;

diff --git a/packages/eslint-plugin/tests/rules/padding-line-between-statements.test.ts b/packages/eslint-plugin/tests/rules/padding-line-between-statements.test.ts
@@ -5056,5 +5056,45 @@ var a = 1
         { messageId: 'expectedBlankLine' },
       ],
     },
+    {
+      // https://github.com/typescript-eslint/typescript-eslint/issues/3863
+      code: `
+declare namespace Types {
+  type Foo = string;
+  type Bar = string;
+  interface FooBar {
+    [key: string]: string;
+  }
+  interface BarBaz {
+    [key: string]: string;
+  }
+}
+      `,
+      output: `
+declare namespace Types {
+  type Foo = string;
+
+  type Bar = string;
+
+  interface FooBar {
+    [key: string]: string;
+  }
+
+  interface BarBaz {
+    [key: string]: string;
+  }
+}
+
+      `,
+      options: [
+        { blankLine: 'always', prev: '*', next: ['interface', 'type'] },
+      ],
+      errors: [
+        { messageId: 'expectedBlankLine' },
+        { messageId: 'expectedBlankLine' },
+        { messageId: 'expectedBlankLine' },
+        { messageId: 'expectedBlankLine' },
+      ],
+    },
   ],
 });