Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(eslint-plugin): add prefer-string-starts-ends-with rule (fixes #285
- Loading branch information
1 parent
1464696
commit 0a10459
Showing
7 changed files
with
1,825 additions
and
3 deletions.
There are no files selected for viewing
54 changes: 54 additions & 0 deletions
54
packages/eslint-plugin/docs/rules/prefer-string-starts-ends-with.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
# Enforce to use `String#startsWith` and `String#endsWith` over other options (prefer-string-starts-ends-with) | ||
|
||
There are multiple ways to verify if a string starts or ends with a specific string, auch as `foo.indexOf('bar') === 0`. | ||
|
||
Since ES2015 has added `String#startsWith` and `String#endsWith`, this rule reports other ways to be consistent. | ||
|
||
## Rule Details | ||
|
||
This rule is aimed at enforcing the consistent way that checks a string starts or ends with a specific string. | ||
|
||
Examples of **incorrect** code for this rule: | ||
|
||
```ts | ||
let foo: string | ||
|
||
// starts with | ||
foo[0] === 'b' | ||
foo.charAt(0) === 'b' | ||
foo.indexOf('bar') === 0 | ||
foo.slice(0, 3) === 'bar' | ||
foo.substring(0, 3) === 'bar' | ||
foo.match(/^bar/) | ||
/^bar/.test(foo) | ||
|
||
// ends with | ||
foo[foo.length - 1] === 'b' | ||
foo.charAt(foo.length - 1) === 'b' | ||
foo.lastIndexOf('bar') === foo.length - 3 | ||
foo.slice(-3) === 'bar' | ||
foo.substring(foo.length - 3) === 'bar' | ||
foo.match(/bar$/) | ||
/bar$/.test(foo) | ||
``` | ||
|
||
Examples of **correct** code for this rule: | ||
|
||
```ts | ||
foo.startsWith('bar'); | ||
foo.endsWith('bar'); | ||
``` | ||
|
||
## Options | ||
|
||
There is no option. | ||
|
||
```JSON | ||
{ | ||
"@typescript-eslint/prefer-string-starts-ends-with": "error" | ||
} | ||
``` | ||
|
||
## When Not To Use It | ||
|
||
If you don't mind that style, you can turn this rule off safely. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.