fix: pass error to pgpool release #9209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This extends github PR typeorm#7792 to pass the error, if any, to the release callback from `pg-pool`. This should be done to ensure the connection is removed from the pool, as described in typeorm#5112.
|
Thank you for contribution! 🎉 |
wirekang
pushed a commit
to wirekang/typeorm
that referenced
this pull request
Aug 25, 2022
This extends github PR typeorm#7792 to pass the error, if any, to the release callback from `pg-pool`. This should be done to ensure the connection is removed from the pool, as described in typeorm#5112.
nordinh
pushed a commit
to nordinh/typeorm
that referenced
this pull request
Aug 29, 2022
This extends github PR typeorm#7792 to pass the error, if any, to the release callback from `pg-pool`. This should be done to ensure the connection is removed from the pool, as described in typeorm#5112.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
I believe the intent in #7792 was to pass the error, if any, to the release callback from
pg-pool, but it doesn't look like the error wasn't actually propagated through that release callback. The original issue (#5112) describes the motivation. #9055 also looks related.Existing tests don't appear to cover this branch, and I haven't added any here. I validated this by adding logging and following the suggested steps in #5112: issue a long-running query, and kill the process or container. I note that with the steps I took, pg-pool still managed to clean up properly by seeing that the client is not
_queryable, but I imagine there are cases where this wouldn't happen.Pull-Request Checklist
masterbranchnpm run formatto apply prettier formattingnpm run testpasses with this changeFixes #0000