Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: #8914 #8917

Merged
merged 3 commits into from
Aug 22, 2022
Merged

Fix: #8914 #8917

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b5d5317
Fix: await DataSource from export file to support async loading
anton-pavlov-deel Apr 20, 2022
21638f1
fix: prettier errors
anton-pavlov-deel Apr 20, 2022
34555cd
updated code style
pleerock Jun 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/commands/CommandUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,13 @@ export class CommandUtils {
}

const dataSourceExports = []
for (let fileExport in dataSourceFileExports) {
if (
InstanceChecker.isDataSource(dataSourceFileExports[fileExport])
) {
dataSourceExports.push(dataSourceFileExports[fileExport])
for (const fileExport of dataSourceFileExports) {
// It is necessary to await here in case of the exported async value (Promise<DataSource>).
// e.g. the DataSource is instantiated with an async factory in the source file
const awaitedFileExport =
fileExport instanceof Promise ? await fileExport : fileExport
if (InstanceChecker.isDataSource(awaitedFileExport)) {
dataSourceExports.push(awaitedFileExport)
}
}

Expand Down