Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove workaround for "Excessive Stack Depth" from TS3.2 #7996

Conversation

imnotjames
Copy link
Contributor

@imnotjames imnotjames commented Jul 31, 2021

Description of change

this was added to our typing to work around issue described in
microsoft/TypeScript#21592 - however, as of TS 3.6.3 it has not been
an issue

fixes #7338

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run lint passes with this change
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions explained in CONTRIBUTING.md

this was added to our typing to work around issue described in
microsoft/TypeScript#21592 - however, as of TS 3.6.3 it has not been
an issue
@imnotjames imnotjames merged commit f7eb46d into typeorm:master Jul 31, 2021
@imnotjames imnotjames deleted the fix/7338/remove-findconditions-workaround branch July 31, 2021 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't use FindConditions with generics
1 participant