Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix expo sqlite driver disconnect() #6027

Merged
merged 1 commit into from May 15, 2020
Merged

Fix expo sqlite driver disconnect() #6027

merged 1 commit into from May 15, 2020

Commits on May 7, 2020

  1. Fix expo sqlite driver disconnect() 

    Currently the disconnect() function does not perform a call to databaseConnection close, it only sets the
queryRunner and databaseConnection to undefined, this behavior may cause problems when you do something like this:

1 - await getConnection().close();
2 - Replace the database file
3 - Try to open connection createConnection(); and do some insert

more info:
expo/expo#8109
    @allandiego
    allandiego committed May 7, 2020
    Copy the full SHA
    7cc7922 View commit details
    Browse the repository at this point in the history