postgres: return whole result on updates and deletes #2944
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently on updates and deletes nothing useful is returned to the caller. By returning the whole result from the postgres driver we can know how many rows were altered, etc.
|
This doesn't seem to be possible without breaking changes. |
|
May I ask why this issue was closed? Currently the updates return a result object. Is it not possible to augment that one instead of changing it completely? |
|
From what I saw there are several places that assume that you only return the ‘rows’ attribute of the result object, and thus miss out on other interesting info. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently on updates and deletes nothing useful is returned to the caller. By returning the whole result from the postgres driver we can know how many rows were altered, etc.
Addresses: #2415, #1308, #2578