Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: stop column transformers from modifying where #10847

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: stop column transformers from modifying where #10847

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
23 changes: 20 additions & 3 deletions src/find-options/FindOperator.ts
View file
Open in desktop
Expand Up @@ -138,11 +138,26 @@ export class FindOperator<T> {
return this._getSql
}

transformValue(transformer: ValueTransformer | ValueTransformer[]) {
clone() {
return new FindOperator(
this._type,
this._value,
this._useParameter,
this._multipleParameters,
this._getSql,
this._objectLiteralParameters,
)
}

transformValue(
transformer: ValueTransformer | ValueTransformer[],
): T | FindOperator<T> {
const cloned = this.clone()

if (this._value instanceof FindOperator) {
this._value.transformValue(transformer)
cloned._value = this._value.transformValue(transformer)
} else {
this._value =
cloned._value =
Array.isArray(this._value) && this._multipleParameters
? this._value.map(
(v: any) =>
Expand All @@ -157,5 +172,7 @@ export class FindOperator<T> {
this._value,
)
}

return cloned
}
}
17 changes: 10 additions & 7 deletions src/query-builder/SelectQueryBuilder.ts
View file
Open in desktop
Expand Up @@ -4271,13 +4271,16 @@ export class SelectQueryBuilder<Entity extends ObjectLiteral>
parameterValue = where[key].value
}
if (column.transformer) {
parameterValue instanceof FindOperator
? parameterValue.transformValue(column.transformer)
: (parameterValue =
ApplyValueTransformers.transformTo(
column.transformer,
parameterValue,
))
if (parameterValue instanceof FindOperator) {
parameterValue = parameterValue.transformValue(
column.transformer,
)
} else {
parameterValue = ApplyValueTransformers.transformTo(
column.transformer,
parameterValue,
)
}
}

// if (parameterValue === null) {
Expand Down