Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(query-runner): use Date.now() intead of +new Date() #10811

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

perf(query-runner): use Date.now() intead of +new Date() #10811

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/driver/better-sqlite3/BetterSqlite3QueryRunner.ts
View file
Open in desktop
Expand Up @@ -84,7 +84,7 @@ export class BetterSqlite3QueryRunner extends AbstractSqliteQueryRunner {
const connection = this.driver.connection

this.driver.connection.logger.logQuery(query, parameters, this)
const queryStartTime = +new Date()
const queryStartTime = Date.now()

const stmt = await this.getStmt(query)

Expand All @@ -108,7 +108,7 @@ export class BetterSqlite3QueryRunner extends AbstractSqliteQueryRunner {
// log slow queries if maxQueryExecution time is set
const maxQueryExecutionTime =
this.driver.options.maxQueryExecutionTime
const queryEndTime = +new Date()
const queryEndTime = Date.now()
const queryExecutionTime = queryEndTime - queryStartTime
if (
maxQueryExecutionTime &&
Expand Down
4 changes: 2 additions & 2 deletions src/driver/cockroachdb/CockroachQueryRunner.ts
View file
Open in desktop
Expand Up @@ -281,7 +281,7 @@ export class CockroachQueryRunner
parameters,
)

const queryStartTime = +new Date()
const queryStartTime = Date.now()

if (this.isTransactionActive && this.storeQueries) {
this.queries.push({ query, parameters })
Expand All @@ -299,7 +299,7 @@ export class CockroachQueryRunner
// log slow queries if maxQueryExecution time is set
const maxQueryExecutionTime =
this.driver.options.maxQueryExecutionTime
const queryEndTime = +new Date()
const queryEndTime = Date.now()
const queryExecutionTime = queryEndTime - queryStartTime
if (
maxQueryExecutionTime &&
Expand Down
4 changes: 2 additions & 2 deletions src/driver/cordova/CordovaQueryRunner.ts
View file
Open in desktop
Expand Up @@ -62,7 +62,7 @@ export class CordovaQueryRunner extends AbstractSqliteQueryRunner {
parameters,
)

const queryStartTime = +new Date()
const queryStartTime = Date.now()

try {
const raw = await new Promise<any>(async (ok, fail) => {
Expand All @@ -77,7 +77,7 @@ export class CordovaQueryRunner extends AbstractSqliteQueryRunner {
// log slow queries if maxQueryExecution time is set
const maxQueryExecutionTime =
this.driver.options.maxQueryExecutionTime
const queryEndTime = +new Date()
const queryEndTime = Date.now()
const queryExecutionTime = queryEndTime - queryStartTime

this.broadcaster.broadcastAfterQueryEvent(
Expand Down
4 changes: 2 additions & 2 deletions src/driver/expo/ExpoQueryRunner.ts
View file
Open in desktop
Expand Up @@ -174,7 +174,7 @@ export class ExpoQueryRunner extends AbstractSqliteQueryRunner {
parameters,
)

const queryStartTime = +new Date()
const queryStartTime = Date.now()
// All Expo SQL queries are executed in a transaction context
databaseConnection.transaction(
async (transaction: ITransaction) => {
Expand All @@ -189,7 +189,7 @@ export class ExpoQueryRunner extends AbstractSqliteQueryRunner {
// log slow queries if maxQueryExecution time is set
const maxQueryExecutionTime =
this.driver.options.maxQueryExecutionTime
const queryEndTime = +new Date()
const queryEndTime = Date.now()
const queryExecutionTime =
queryEndTime - queryStartTime

Expand Down
4 changes: 2 additions & 2 deletions src/driver/mysql/MysqlQueryRunner.ts
View file
Open in desktop
Expand Up @@ -203,15 +203,15 @@ export class MysqlQueryRunner extends BaseQueryRunner implements QueryRunner {
parameters,
)

const queryStartTime = +new Date()
const queryStartTime = Date.now()
databaseConnection.query(
query,
parameters,
async (err: any, raw: any) => {
// log slow queries if maxQueryExecution time is set
const maxQueryExecutionTime =
this.driver.options.maxQueryExecutionTime
const queryEndTime = +new Date()
const queryEndTime = Date.now()
const queryExecutionTime = queryEndTime - queryStartTime

if (
Expand Down
4 changes: 2 additions & 2 deletions src/driver/nativescript/NativescriptQueryRunner.ts
View file
Open in desktop
Expand Up @@ -63,7 +63,7 @@ export class NativescriptQueryRunner extends AbstractSqliteQueryRunner {
// log slow queries if maxQueryExecution time is set
const maxQueryExecutionTime =
this.driver.options.maxQueryExecutionTime
const queryEndTime = +new Date()
const queryEndTime = Date.now()
const queryExecutionTime = queryEndTime - queryStartTime

if (
Expand Down Expand Up @@ -101,7 +101,7 @@ export class NativescriptQueryRunner extends AbstractSqliteQueryRunner {
ok(result.raw)
}
}
const queryStartTime = +new Date()
const queryStartTime = Date.now()

if (isInsertQuery) {
databaseConnection.execSQL(query, parameters, handler)
Expand Down
4 changes: 2 additions & 2 deletions src/driver/oracle/OracleQueryRunner.ts
View file
Open in desktop
Expand Up @@ -209,7 +209,7 @@ export class OracleQueryRunner extends BaseQueryRunner implements QueryRunner {
parameters,
)

const queryStartTime = +new Date()
const queryStartTime = Date.now()

try {
const executionOptions = {
Expand All @@ -226,7 +226,7 @@ export class OracleQueryRunner extends BaseQueryRunner implements QueryRunner {
// log slow queries if maxQueryExecution time is set
const maxQueryExecutionTime =
this.driver.options.maxQueryExecutionTime
const queryEndTime = +new Date()
const queryEndTime = Date.now()
const queryExecutionTime = queryEndTime - queryStartTime

this.broadcaster.broadcastAfterQueryEvent(
Expand Down
8 changes: 4 additions & 4 deletions src/driver/postgres/PostgresQueryRunner.ts
View file
Open in desktop
Expand Up @@ -256,12 +256,12 @@ export class PostgresQueryRunner
)

try {
const queryStartTime = +new Date()
const queryStartTime = Date.now()
const raw = await databaseConnection.query(query, parameters)
// log slow queries if maxQueryExecution time is set
const maxQueryExecutionTime =
this.driver.options.maxQueryExecutionTime
const queryEndTime = +new Date()
const queryEndTime = Date.now()
const queryExecutionTime = queryEndTime - queryStartTime

this.broadcaster.broadcastAfterQueryEvent(
Expand Down Expand Up @@ -601,7 +601,7 @@ export class PostgresQueryRunner
downQueries.push(this.dropIndexSql(table, index))
})
}

if (table.comment) {
upQueries.push(new Query("COMMENT ON TABLE " + this.escapePath(table) + " IS '" + table.comment + "'"));
downQueries.push(new Query("COMMENT ON TABLE " + this.escapePath(table) + " IS NULL"));
Expand Down Expand Up @@ -4744,7 +4744,7 @@ export class PostgresQueryRunner

newComment = this.escapeComment(newComment)
const comment = this.escapeComment(table.comment)

if (newComment === comment) {
return
}
Expand Down
4 changes: 2 additions & 2 deletions src/driver/react-native/ReactNativeQueryRunner.ts
View file
Open in desktop
Expand Up @@ -63,15 +63,15 @@ export class ReactNativeQueryRunner extends AbstractSqliteQueryRunner {
parameters,
)

const queryStartTime = +new Date()
const queryStartTime = Date.now()
databaseConnection.executeSql(
query,
parameters,
async (raw: any) => {
// log slow queries if maxQueryExecution time is set
const maxQueryExecutionTime =
this.driver.options.maxQueryExecutionTime
const queryEndTime = +new Date()
const queryEndTime = Date.now()
const queryExecutionTime = queryEndTime - queryStartTime

this.broadcaster.broadcastAfterQueryEvent(
Expand Down
4 changes: 2 additions & 2 deletions src/driver/sap/SapQueryRunner.ts
View file
Open in desktop
Expand Up @@ -207,7 +207,7 @@ export class SapQueryRunner extends BaseQueryRunner implements QueryRunner {
parameters,
)

const queryStartTime = +new Date()
const queryStartTime = Date.now()
const isInsertQuery = query.substr(0, 11) === "INSERT INTO"

if (parameters?.some(Array.isArray)) {
Expand All @@ -232,7 +232,7 @@ export class SapQueryRunner extends BaseQueryRunner implements QueryRunner {
// log slow queries if maxQueryExecution time is set
const maxQueryExecutionTime =
this.driver.connection.options.maxQueryExecutionTime
const queryEndTime = +new Date()
const queryEndTime = Date.now()
const queryExecutionTime = queryEndTime - queryStartTime

this.broadcaster.broadcastAfterQueryEvent(
Expand Down
8 changes: 4 additions & 4 deletions src/driver/spanner/SpannerQueryRunner.ts
View file
Open in desktop
Expand Up @@ -159,7 +159,7 @@ export class SpannerQueryRunner extends BaseQueryRunner implements QueryRunner {
const broadcasterResult = new BroadcasterResult()

try {
const queryStartTime = +new Date()
const queryStartTime = Date.now()
await this.connect()
let rawResult:
| [
Expand Down Expand Up @@ -216,7 +216,7 @@ export class SpannerQueryRunner extends BaseQueryRunner implements QueryRunner {
// log slow queries if maxQueryExecution time is set
const maxQueryExecutionTime =
this.driver.options.maxQueryExecutionTime
const queryEndTime = +new Date()
const queryEndTime = Date.now()
const queryExecutionTime = queryEndTime - queryStartTime

this.broadcaster.broadcastAfterQueryEvent(
Expand Down Expand Up @@ -286,15 +286,15 @@ export class SpannerQueryRunner extends BaseQueryRunner implements QueryRunner {

this.driver.connection.logger.logQuery(query, parameters, this)
try {
const queryStartTime = +new Date()
const queryStartTime = Date.now()
const [operation] = await this.driver.instanceDatabase.updateSchema(
query,
)
await operation.promise()
// log slow queries if maxQueryExecution time is set
const maxQueryExecutionTime =
this.driver.options.maxQueryExecutionTime
const queryEndTime = +new Date()
const queryEndTime = Date.now()
const queryExecutionTime = queryEndTime - queryStartTime
if (
maxQueryExecutionTime &&
Expand Down
4 changes: 2 additions & 2 deletions src/driver/sqlite/SqliteQueryRunner.ts
View file
Open in desktop
Expand Up @@ -75,7 +75,7 @@ export class SqliteQueryRunner extends AbstractSqliteQueryRunner {
try {
const databaseConnection = await this.connect()
this.driver.connection.logger.logQuery(query, parameters, this)
const queryStartTime = +new Date()
const queryStartTime = Date.now()
const isInsertQuery = query.startsWith("INSERT ")
const isDeleteQuery = query.startsWith("DELETE ")
const isUpdateQuery = query.startsWith("UPDATE ")
Expand All @@ -101,7 +101,7 @@ export class SqliteQueryRunner extends AbstractSqliteQueryRunner {
}

// log slow queries if maxQueryExecution time is set
const queryEndTime = +new Date()
const queryEndTime = Date.now()
const queryExecutionTime = queryEndTime - queryStartTime
if (
maxQueryExecutionTime &&
Expand Down
4 changes: 2 additions & 2 deletions src/driver/sqljs/SqljsQueryRunner.ts
View file
Open in desktop
Expand Up @@ -94,7 +94,7 @@ export class SqljsQueryRunner extends AbstractSqliteQueryRunner {
parameters,
)

const queryStartTime = +new Date()
const queryStartTime = Date.now()
let statement: any
try {
statement = databaseConnection.prepare(query)
Expand All @@ -109,7 +109,7 @@ export class SqljsQueryRunner extends AbstractSqliteQueryRunner {
// log slow queries if maxQueryExecution time is set
const maxQueryExecutionTime =
this.driver.options.maxQueryExecutionTime
const queryEndTime = +new Date()
const queryEndTime = Date.now()
const queryExecutionTime = queryEndTime - queryStartTime

if (
Expand Down
4 changes: 2 additions & 2 deletions src/driver/sqlserver/SqlServerQueryRunner.ts
View file
Open in desktop
Expand Up @@ -246,14 +246,14 @@ export class SqlServerQueryRunner
}
})
}
const queryStartTime = +new Date()
const queryStartTime = Date.now()

const raw = await new Promise<any>((ok, fail) => {
request.query(query, (err: any, raw: any) => {
// log slow queries if maxQueryExecution time is set
const maxQueryExecutionTime =
this.driver.options.maxQueryExecutionTime
const queryEndTime = +new Date()
const queryEndTime = Date.now()
const queryExecutionTime = queryEndTime - queryStartTime

this.broadcaster.broadcastAfterQueryEvent(
Expand Down