feat: remove hdb-pool dependency from HANA driver #10786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit also removes unused code and fix some typos.
This commit updates how SapDriver establishes connection with HANA, as mentioned in the "Node.js Typescript Support" section of the official documentation.
viniscoelho
force-pushed
the
poc-remove-hdb-pool
branch
from
d05335c
to
69b3328
Compare
|
HI @viniscoelho , may I ask if there is something missing to get this PR merged? |
Hi @dcdieci, it is ready to be merged. I've managed to establish a connection with HANA express by running the tests. |
|
@viniscoelho Thanks a lot for the fast reply. I am very much looking forward to this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Fixes #9890.
I have updated the SapDriver to use Node.js Connection Pooling, as pointed out by hdb-pool repo: https://help.sap.com/docs/SAP_HANA_CLIENT/f1b440ded6144a54ada97ff95dac7adf/e252ff9b2cb44dd9925901e39025ce77.html?q=connectionLifetime
I've also managed to connect with HANA express and run some tests. However, since the tests are too generic, there are some scenarios which fail as they do not exist on HANA.
Pull-Request Checklist
masterbranchnpm run formatto apply prettier formattingnpm run testpasses with this changeFixes #9890