Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update mongodb in peerDependencies #10746

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

starnayuta
Copy link

Description of change

Fixes #10686

Update mongodb in peerDependencies that was not changed in #10545.

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run format to apply prettier formatting
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions explained in CONTRIBUTING.md

@noam-moshe
Copy link

noam-moshe commented Apr 30, 2024

This PR should resolve issue #10842
Can you please look at this? @pleerock @NoNameProvided

@NoNameProvided
Copy link
Member

I am not a maintainer of TypeORM, I never was.

@franciscosucre
Copy link

@pleerock this pull request would make life a lot easier for our company, where we used mongo with the 6.0 driver but want to use typeORM for SQL.

A similar PR was merged in #10545 but only with the devDependencies.

If there is any way we can help to make this pull requests to be released?

Thanks!

@muditjai
Copy link

Please merge this PR. I'm blocked on it.

@franciscosucre
Copy link

For anyone still stuck with this, this workaround worked for us

imagen

Introduce this property in your package.json, with the appropiate version of the mongodb driver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mongodb >6.X only into devDependencies and not into peerDependencies
5 participants