fix: prevent reuse of broken connections in postgres pool #7792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imnotjames
force-pushed
the
fix/5112/prevent-postgres-reusing-broken
branch
from
fb01d9d
to
d655e05
Compare
this updates the error handler we have on the postgres connection object to release back with an error in the case of an error so the underlying `pg-pool` knows to remove the connection from the rotation
imnotjames
force-pushed
the
fix/5112/prevent-postgres-reusing-broken
branch
from
d655e05
to
7ed816e
Compare
bryfox
added a commit
to bryfox/typeorm
that referenced
this pull request
Jul 16, 2022
This extends github PR typeorm#7792 to pass the error, if any, to the release callback from `pg-pool`. This should be done to ensure the connection is removed from the pool, as described in typeorm#5112.
7 tasks
pleerock
pushed a commit
that referenced
this pull request
Aug 24, 2022
wirekang
pushed a commit
to wirekang/typeorm
that referenced
this pull request
Aug 25, 2022
This extends github PR typeorm#7792 to pass the error, if any, to the release callback from `pg-pool`. This should be done to ensure the connection is removed from the pool, as described in typeorm#5112.
nordinh
pushed a commit
to nordinh/typeorm
that referenced
this pull request
Aug 29, 2022
This extends github PR typeorm#7792 to pass the error, if any, to the release callback from `pg-pool`. This should be done to ensure the connection is removed from the pool, as described in typeorm#5112.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
fixes #5112
passes the error back to the
pg-poolrelease callback.there aren't tests, though - because we don't really do mocking of the database for our tests & forcing a failing database is rather difficult. until we can more gracefully do mocks / spies / etc, I'm not sure the best way to verify this functionality.
I did verify it by running a long running query,
kill -TERMing the postgres database & then observing the code flow.Pull-Request Checklist
masterbranchnpm run lintpasses with this changenpm run testpasses with this changeFixes #0000