Extract some code from yaml test item #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this a SystemExit exception could return the code as a string or an integer, now we convert it to a sensible integer to return
It currently doesn't depend on the execution path existing, and we can make sure this runs before we create that path and run anything
This is so we can abstract away what is involved in checking the mypy output. This will also help when we extract running mypy so we don't have to pass around the information that is only needed for this check
This will make it easier for us to run mypy multiple times later on
This object glues together the creation of test files, the running of mypy, and the checking of the result
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I have some time to make #144 happen (and the need for this functionality).
I haven't got far into working out exactly how I'll make it happen, but I do believe it'll be easier if
YamlTestItemis broken up a bit.This PR is a refactor do do that. It should be a pure refactor and I believe the only real change is I do move
execute_extension_hookto before theexecution_pathis created, as it currently does not know about that folder.I want to make sure I'm not gonna be treading on any toes before going too far down this path!
This PR is best seen one commit at a time.