Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move mypy version upper bound to a [compatible-mypy] extra #979

Merged
merged 2 commits into from Jun 4, 2022

Commits on Jun 3, 2022

  1. Move mypy version upper bound to a [compatible-mypy] extra

    Due to a bug in mypy 0.940 (typeddjango#870), we made two changes in typeddjango#871:
    
    • pinned mypy==0.931 in requirements.txt (for running our tests);
    • bounded mypy<0.940 in setup.py (for downstream users).
    
    After the mypy bug was quickly fixed upstream in 0.941, our setup.py
    bound has been repeatedly raised but not removed (typeddjango#886, typeddjango#939, typeddjango#973).
    The only changes in those commits have been to the precise wording of
    error messages expected in our tests.  Those wording changes don’t
    impact compatibility for downstream users, so it should be safe to go
    back to allowing them to upgrade mypy independently.
    
    Since mypy doesn’t yet guarantee backwards compatibility in the plugin
    API (although in practice it has rarely been an issue), add a
    django-stubs[compatible-mypy] extra for users who prefer a known-good
    version of mypy even if it’s a little out of date.
    
    Signed-off-by: Anders Kaseorg <andersk@mit.edu>
    andersk committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    5554faf View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2022

  1. Update setup.py

    sobolevn committed Jun 4, 2022
    Configuration menu
    Copy the full SHA
    535fd90 View commit details
    Browse the repository at this point in the history